After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331509 - Folder subscription : subscribe button is not enabled when i select a folder.
Folder subscription : subscribe button is not enabled when i select a folder.
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.6.x (obsolete)
Other Linux
: Normal normal
: Future
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks: 339777
 
 
Reported: 2006-02-17 05:52 UTC by Sushma Rai
Modified: 2013-09-13 00:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch - removes the callback for buttons. (3.57 KB, patch)
2006-07-24 08:11 UTC, Sushma Rai
reviewed Details | Review
Glade file - after removing the buttons (59.53 KB, application/xml)
2006-07-24 08:14 UTC, Sushma Rai
  Details
Patch - diff for the glade file (6.31 KB, patch)
2006-07-24 08:28 UTC, Sushma Rai
committed Details | Review

Description Sushma Rai 2006-02-17 05:52:24 UTC
The folder subscription dialog allows 2 ways of selecting a 
folder for subscribing.
1. by clicking on the check box and
2. by using the subscibe button.

When I select (highlight) a folder, the subscribe button is not getting 
enabled, I have to enable the check box and say "Close" to subscribe.

Once I enable a folder "Unsubscribe" button gets enabled and 
If I click on "Unsubscribe" button or un-check, 
then only "Subscribe" button gets enabled.

So the first time it is confusing as there is no "OK" button, 
"Subscribe" button remains disabled, and user will not 
be sure if clicking on check box and closing will 
really subscribe or not.
Comment 1 Sushma Rai 2006-02-17 05:54:26 UTC
Might require a UI change, so marked it for future.
Comment 2 Sankar P 2006-02-17 06:03:05 UTC
In my view, it is not necessary to have the Subscribe and the Unsubscribe buttons at all. They confuse instead of clarifying. We can add a label saying that: "All folders checked will be marked for subscription" and have the close butotn alone. Same as the way in which the "Desktop background picture" applet works. 
Comment 3 Srinivasa Ragavan 2006-02-17 06:13:55 UTC
Both the buttons can be removed. Also than (tick) on a parent has to have some action. Target for future.
Comment 4 Sushma Rai 2006-07-24 08:11:58 UTC
Created attachment 69457 [details] [review]
Patch - removes the callback for buttons.
Comment 5 Sushma Rai 2006-07-24 08:14:11 UTC
Created attachment 69458 [details]
Glade file - after removing the buttons
Comment 6 Srinivasa Ragavan 2006-07-24 08:20:38 UTC
Are you sure about the glade changes. It changes more than what it is supposed to do.

The patch is OK otherwise except the right fmt of if/else may be reset by ur patch.
Comment 7 Sushma Rai 2006-07-24 08:28:43 UTC
Created attachment 69459 [details] [review]
Patch - diff for the glade file

Above was the glade file itself. Here is the diff
Comment 8 Sushma Rai 2006-07-24 09:25:59 UTC
committed to cvs head.