After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331484 - Should not include Accessibility_Registry.server in tarball
Should not include Accessibility_Registry.server in tarball
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: registry
unspecified
Other All
: Normal critical
: ---
Assigned To: bill.haneman
bill.haneman
: 331610 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-02-17 00:30 UTC by Brian Cameron
Modified: 2006-02-20 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix which removed .server from DIST (2.42 KB, patch)
2006-02-17 13:30 UTC, bill.haneman 		none Details | Review

Description Brian Cameron 2006-02-17 00:30:41 UTC 
Currently the registryd/Makefile.am includes $(serverinfo_DATA) in EXTRA_DIST.  This file should be rebuilt from the Accessibility_Registery.server.in.in, but
since the generated file gets included in the tarball with a later datestamp than the *.in.in file, it doesn't rebuild.

This file includes /usr/libexec/at-spi-registryd in the at-spi 1.7.4 version of the tarball which causes breakage in Solaris where this is shipped in /usr/lib.

It would be better to simply remove $(serverinfo_DATA) from EXTRA_DIST so this
file is always regenerated when building with the proper libexecdir specified by configure options.
Comment 1 bill.haneman 2006-02-17 11:51:54 UTC 
Not sure I agree that .server.in.in should be the file in the dist, as frankly I don't see any good reason to localize this server file (as the end user never interacts directly with this service or invokes it).  In that case, it's the .server.in file that should be included in the dist I suppose.
Comment 2 bill.haneman 2006-02-17 13:30:08 UTC 
Created attachment 59577 [details] [review]
Fix which removed .server from DIST
Comment 3 bill.haneman 2006-02-17 17:27:53 UTC 
Thanks a lot Brian for catching this.  I'm having trouble with my fix, since it seems that reinstating at-spi localization is the best approach.  See my patch to bug 322846 for the current problem.

Just removing the .server file from the dist would be the brute force fix but the path of least resistance seems to be reinstating localization.  It seems that the .server file was always in the at-spi dist (incorrectly), but because of the previous use of intltool, it wasn't biting us in the way it did in 1.7.4. (It only became a problem when we stopped using intltool to create the .server.in file from .server.in.in)
Comment 4 bill.haneman 2006-02-20 14:33:12 UTC 
*** Bug 331610 has been marked as a duplicate of this bug. ***
Comment 5 bill.haneman 2006-02-20 15:05:32 UTC 
Fixed in cvs and in at-spi-1.7.5.