GNOME Bugzilla – Bug 331132
preferences menu unclear about what sleep times mean
Last modified: 2006-02-19 11:22:58 UTC
I don't know whether "Put ... to sleep after" is "after x minutes of inactivity" or just "after x minutes". I suppose it's obvious for AC, but less so for battery and it took me some thought to decide that it must be after minutes of inactivity. This should be clarified. Other information:
What do you think the text should be? 21 minutes Put computer to sleep after session become idle: =======[]============ Or just add a help comment? I'm also thinking of changing the idle type in options to: |- Idle Options-- Inactivity sleep type: [combobox] or something different?
(In reply to comment #1) > What do you think the text should be? > > 21 minutes > Put computer to sleep after session become idle: =======[]============ If the string is so long we have to put the slider below it. session is jargon. Apple does Put computer to sleep when it is inactive for: ==============[]========================================== 21 minutes Put the display to sleep when the computer is inactive for: ===============[]=========================================== 21 minutes > > Or just add a help comment? > > I'm also thinking of changing the idle type in options to: > > |- Idle Options-- > > Inactivity sleep type: [combobox] Sleep type when inactive: [combobox] ??? > or something different? >
Created attachment 59551 [details] [review] Patch containing my proposal What do you think of think of this? I really like that the sliders are longer than they used to be
Created attachment 59558 [details] screenshot I like it, it seems more obvious what each slider does. I've attached a screenshot for those that don't speak XML :-) Minor nit, I think the gap between the ac display slider and the "Running on Batteries" is too large, but I'm no expert.
Created attachment 59561 [details] a new layout? What about going one step further and doing something like this? It would also solve our "laptop action on lid close" and our "when do we lock the screen" issues. I've been thinking about doing this for a long time.
Okay here's some thoughts... First, 'Running on AC' I'd put the display sleep above the computer sleep In the actions section I'd make "Lock screen" be "Also lock screen" and I'd ensure the human readable items in the combo would be "Do not sleep", "Suspend" and "Hibernate" Running on battery page, pretty much the same comments again options page, "Lock screen on resume" seems odd, "Also lock screen" would work better here too and save on translation strings. The 'when suspend button pressed' lacks the tickybox Now this dialog I think is not *too* complex but it certainly is more complex than the current one. Personally with the above changes I'd give it a +1, but I am not scared by complex dialogs. Jaap, is is too complex now?
Created attachment 59573 [details] new glade file Okay, I've changed most of suggestions... The "do not suspend text" is in src, we can change that later. Jaap, Jon, what are your views? I like this new layout a *lot* as it seems more logically correct. And it allows up to seporate functionality that doesn't make sense in one context, such as "Battery power critical".
I showed the new UI to my resident UI bigot and he had some suggestions. First-up (and I agree with him here) the labels needs to line up with the combo boxes rather than being stuck slightly offset due to the tickyboxes. He also dislikes the colons everywhere but I assume that gnome HIG rather than your personal preference.
Oh, he also suggests "running on external power" rather than "on AC"
>First-up (and I agree with him here) the labels needs to line up with the >combo boxes rather than being stuck slightly offset due to the tickyboxes. Yes this is done in the code using a GtkAlignment. If you make install the glade file it'll pop nicely into alignment. I think the GNOME HIG specifies colons, Jaap, correct me if I'm wrong. Running on external power is also good for me. Thanks for the comments.
Bryan Clark had some insightful comments back in the day http://mail.gnome.org/archives/utopia-list/2005-April/msg00057.html http://gnome.org/~clarkbw/designs/power/sleep%20time.png Ideally combining screensaver, display sleep and system sleep in one slider would be awesome, e.g. [----S----D----A-----------] ^ ^ ^ | | system | display screensaver Here you also introduce the requirement that time_screensaver < time_display < time_system which is what's it like in real life.
That sounds nice to me. Except that from this dialog "screensaver" means "idle". That will be equivalent to screensaver if the appropriate box is checked in the g-s prefs. It solves the problem that the current gpm sliders don't include (prepend) the time-until-idle that is set from the gnome-screensaver preferences. And allows for different times until idle for on-ac or on-batteries. Maybe you could just set /apps/gnome-screensaver/idle_delay to the appropriate value when on-ac changes?
>It solves the problem that the current gpm sliders don't include (prepend) the >time-until-idle that is set from the gnome-screensaver preferences. And allows >for different times until idle for on-ac or on-batteries. Yes, this needs to be be sorted out. Richard.
I like your change Richard. What about getting that in CVS?
2006-02-18 Richard Hughes <richard@hughsie.com> * data/gpm-prefs.glade: Redesign interface. This is going to break g-p-p for a little while, so please bear with me. Also change duplicate accesskeys (#331538) and remove pointless icons in general tab (#331530). Add lots of lock checkboxes to solve (#331164) but these are disabled for now. We can argue about the defaults later, but I think this is an emotional argument with lots of different use-cases, that cannot be solved with just minimising the UI and making assumptions.
Was that the glade file as discussed in this thread richard? (I guess I really ought to sort out a CVS checkout :-)
Yup, with other various bugs fixed. It needs some Jaap HIG love (please) and connecting up to gpm-prefs. I'll do that this afternoon.
Now I am already a HIG expert ;-) Richard, I didn't mean to encourage you to check the glade file in without changing the code in g-p-p. In general it's not a good idea to check something into CVS which breaks something, because other people checking out CVS might loose a lot of time finding out why it was broke. Anyway I guess you'll fix it soon, so just consider it as advice for the future
Oops, I misunderstood your comment, apologies. CVS should be fixed now: 2006-02-18 Richard Hughes <richard@hughsie.com> * data/gpm-prefs.glade: Minor combobox id renames. * src/gpm-prefs.c (gpm_prefs_setup_action_combo): Pass this a widget. (setup_page_one, setup_page_two, setup_page_three): replace with setup_battery_sliders, setup_ac_sliders, setup_suspend_button, setup_sleep_type, setup_ac_actions, setup_battery_actions, and setup_icon_policy so that each function is specific to function, not location in the glade file. Also connect up the new widgets, so that it works like before. The new stuff I'm working on now.
Is fixed in CVS by the great Mr. Hughes. Closing this bug