After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330995 - crasher due to lack of error check in eel a11y
crasher due to lack of error check in eel a11y
Status: RESOLVED FIXED
Product: eel
Classification: Deprecated
Component: general
unspecified
Other All
: Normal critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-13 13:46 UTC by bill.haneman
Modified: 2006-02-28 15:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
small patch to cure current symptom (596 bytes, patch)
2006-02-13 13:47 UTC, bill.haneman
committed Details | Review

Description bill.haneman 2006-02-13 13:46:38 UTC
Open evolution with a11y on using new AT-SPI; often crash immediately results.

Stack trace points to SEGV in eel_labeled_image_accessible_get_name, where labeled_image->details->label is referenced without checking to see that labeled_image->details != NULL.  When an accessible's name is requested when it's being destroyed (and the object:state-changed:defunct event is being emitted), this causes SEGV.

Fix is to check labeled_image->details before redirecting.  Attached patch fixes the current symptom, but in fact the problem is quite general, as labeled_image->details is used for indirection without checking in dozens of places in eel_labeled_image.c, so there are potentially plenty of races/SEGVs here.

Bill
Comment 1 bill.haneman 2006-02-13 13:47:49 UTC
Created attachment 59259 [details] [review]
small patch to cure current symptom

better patch would extend this checking throughout eel_labeled_image.c.
Comment 2 Willie Walker 2006-02-23 11:51:12 UTC
On the Orca team, we've noticed fewer Evolution crashes with this patch applied.  It would be great to get this patch in for gnome 2.14.
Comment 3 bill.haneman 2006-02-24 13:45:50 UTC
oops, eel == nautilus, I must have been looking at nautilus stack traces and not evo.  
Comment 4 Christian Neumair 2006-02-24 17:42:57 UTC
> oops, eel == nautilus, I must have been looking at nautilus stack traces and
not evo.

You also have Nautilus stack traces? :)
Comment 5 bill.haneman 2006-02-24 17:47:25 UTC
I don't have them now, because I've applied the patch :-)
Comment 6 Martin Wehner 2006-02-24 19:32:31 UTC
Comment on attachment 59259 [details] [review]
small patch to cure current symptom

Feel free to commmit, thanks.
Comment 7 bill.haneman 2006-02-28 15:16:09 UTC
Thanks Martin.
Comment 8 bill.haneman 2006-02-28 15:19:27 UTC
p.s. Sorry I didn't commit this before Monday's release...