GNOME Bugzilla – Bug 330995
crasher due to lack of error check in eel a11y
Last modified: 2006-02-28 15:19:27 UTC
Open evolution with a11y on using new AT-SPI; often crash immediately results. Stack trace points to SEGV in eel_labeled_image_accessible_get_name, where labeled_image->details->label is referenced without checking to see that labeled_image->details != NULL. When an accessible's name is requested when it's being destroyed (and the object:state-changed:defunct event is being emitted), this causes SEGV. Fix is to check labeled_image->details before redirecting. Attached patch fixes the current symptom, but in fact the problem is quite general, as labeled_image->details is used for indirection without checking in dozens of places in eel_labeled_image.c, so there are potentially plenty of races/SEGVs here. Bill
Created attachment 59259 [details] [review] small patch to cure current symptom better patch would extend this checking throughout eel_labeled_image.c.
On the Orca team, we've noticed fewer Evolution crashes with this patch applied. It would be great to get this patch in for gnome 2.14.
oops, eel == nautilus, I must have been looking at nautilus stack traces and not evo.
> oops, eel == nautilus, I must have been looking at nautilus stack traces and not evo. You also have Nautilus stack traces? :)
I don't have them now, because I've applied the patch :-)
Comment on attachment 59259 [details] [review] small patch to cure current symptom Feel free to commmit, thanks.
Thanks Martin.
p.s. Sorry I didn't commit this before Monday's release...