After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330964 - drag&dropped email link is appended to the end of the document,
drag&dropped email link is appended to the end of the document,
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-13 08:08 UTC by bugreports
Modified: 2008-02-27 01:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Place the cursor where the mouse was before inserting the email links (1.07 KB, patch)
2007-02-23 22:25 UTC, Boyd Timothy
needs-work Details | Review
Same solution for the bugzilla plugin. (1.19 KB, patch)
2007-02-23 22:32 UTC, Boyd Timothy
needs-work Details | Review
Fix for evo and bugzilla plugins. Factor in TextView.VisibleRect. (2.49 KB, patch)
2007-02-23 22:57 UTC, Boyd Timothy
none Details | Review
Fixes bugzilla, evolution, and NoteWindow drag and drop cursor position (3.28 KB, patch)
2007-02-26 18:31 UTC, Boyd Timothy
committed Details | Review

Description bugreports 2006-02-13 08:08:47 UTC
Please describe the problem:
Any drag & dropped Email link is only appended to the end of the document, not as
expected to the cursor position ! 

Steps to reproduce:
1. just create some note with some text
2. drag and drop an email to the beginning of the note
3. -> it will appear at the bottom


Actual results:


Expected results:


Does this happen every time?
yes 100% reproducable

Other information:
Comment 1 Mårten Woxberg 2006-05-16 10:33:06 UTC
Confirmed
Comment 2 Boyd Timothy 2007-02-23 20:53:33 UTC
It's actually dropping it at the last place the cursor was before losing window focus.  It's still a problem though, because drag and drop indicates the cursor directly under the mouse making the user think that the email link will be inserted at the displayed cursor position.
Comment 3 Boyd Timothy 2007-02-23 22:25:53 UTC
Created attachment 83200 [details] [review]
Place the cursor where the mouse was before inserting the email links
Comment 4 Boyd Timothy 2007-02-23 22:32:09 UTC
Created attachment 83201 [details] [review]
Same solution for the bugzilla plugin.
Comment 5 Boyd Timothy 2007-02-23 22:44:39 UTC
Hmm, looks like both of these patches need a bit of work.  If the note is larger and the window is scrolled down, the TextIter.Offset is wrong and ends up inserting the dropped link earlier in the TextBuffer.
Comment 6 Boyd Timothy 2007-02-23 22:57:57 UTC
Created attachment 83202 [details] [review]
Fix for evo and bugzilla plugins.  Factor in TextView.VisibleRect.
Comment 7 Boyd Timothy 2007-02-23 23:12:10 UTC
Need to add Buffer.PlaceCursor (cursor) in the bugzilla plugin as well.  Also all the other drag and drop from file uri need this functionality as well.
Comment 8 Boyd Timothy 2007-02-26 18:31:17 UTC
Created attachment 83403 [details] [review]
Fixes bugzilla, evolution, and NoteWindow drag and drop cursor position
Comment 9 Boyd Timothy 2007-02-26 18:43:50 UTC
Committed to SVN revision 1001.
Comment 10 Boyd Timothy 2007-02-26 21:01:19 UTC
Marking this as fixed/closed in the 0.5.9 release.
Comment 11 Boyd Timothy 2008-02-27 01:30:38 UTC
Modifying default assignee and qa contact to be tomboy-maint@gnome.bugs.