After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330915 - vfolder description message is not marked as localizable
vfolder description message is not marked as localizable
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.6.x
Other All
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[vfolders]
Depends on:
Blocks: 236276 Persian
 
 
Reported: 2006-02-12 19:43 UTC by Roozbeh Pournader
Modified: 2013-09-13 00:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Patch to fix the problem (1.24 KB, patch)
2006-03-01 18:40 UTC, Roozbeh Pournader
committed Details | Review

Description Roozbeh Pournader 2006-02-12 19:43:20 UTC
Please describe the problem:
The vfolder description message, as defined in
em-folder-tree.c:render_display_name should be made localizable. Currently, it
uses a message saying "%s (%u)" which should be localized for locales that uses
localized digits (including Persian) which would translate it to "%s (%Iu)".
Theoretically, other locales may also wish to replace parentheses with something
else.


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Roozbeh Pournader 2006-03-01 18:40:30 UTC
Created attachment 60417 [details] [review]
Patch to fix the problem

Attaching patch to fix the problem. Please note that this doesn't need approval for breaking the string freeze, as it marks a previously unmarked message for translation. We only need to inform gnome-i18n after we applied the patch.
Comment 2 Behdad Esfahbod 2006-03-01 18:56:09 UTC
I *does* need string change freeze break approval, as it turns 100% into 99.9%.
In fact, when people desperately needed to make changes like this, Danilo suggests that they go ahead with their changes but not mark anything for translation before the next devel cycle.
Comment 3 Tommi Vainikainen 2006-03-01 20:50:28 UTC
http://live.gnome.org/TranslationProject/HandlingStringFreezes clearly says that "Change or addition of a message that is not marked for translation" does NOT affect string freeze. Translations are not about statistics but the real user experience should be measured instead.
Comment 4 Tommi Vainikainen 2006-03-01 20:52:22 UTC
Hmm, it seems I haven't slept enough because I don't understand clear English any more. Later in the freeze explanation page it says "Marking a message for translation that was previously not marked for translation by accident." which this is really about, but it says "by accident".
Comment 5 Behdad Esfahbod 2006-03-01 22:05:47 UTC
It clearly says: """Any addition or change of a string marked for translation (either by gettext or by intltool) in a module included in GNOME 2.13/2.14 is affected by the freeze, apart from the exceptions listed below, and will need announcement and subsequent approval. This is true even for bug fixes that change or alter translateable strings.""" and the exception you are pointing to is clearly about accidents, which is not the case here.

And for what it's worth, seems like it is about statistics in practice ;).
Comment 6 André Klapper 2006-03-02 15:05:45 UTC
tommi: comment #3: i assume that this refers to command line output/debug spewage and stuff like that.

hmm. time to define "accident" i guess. :-/
Comment 7 Danilo Segan 2006-03-02 19:11:41 UTC
Regarding comment #3: Tommi, until we get a "measure of real user experience" instead, it is also about statistics, since that's our only current real measure.
Comment 8 Roozbeh Pournader 2006-05-18 16:38:03 UTC
Would evolution maintainers please give me the approval for the patch for gnome-2-14 and HEAD? I will personally take care of gnome-i18n and the freeze.
Comment 9 Veerapuram Varadhan 2006-08-07 16:16:08 UTC
Please commit the patch to head.
Comment 10 Karsten Bräckelmann 2006-08-07 16:28:21 UTC
Thanks.

Committed to HEAD. Will send string change announcement soon.