After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330796 - video4linux building bugsquash
video4linux building bugsquash
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.x
Other Linux
: Normal minor
: 0.8.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-11 14:56 UTC by Bernard Leak
Modified: 2006-03-22 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Ultra-safe repair for conditionally missing array (604 bytes, patch)
2006-02-11 15:00 UTC, Bernard Leak
rejected Details | Review

Description Bernard Leak 2006-02-11 14:56:20 UTC
*** PATCH KNOWN, WILL FOLLOW ***

Some combination or other of missing or disabled debug options can lead to
the video4linux plugin being compiled WITHOUT the macro GST_DISABLE_GST_DEBUG
being defined (it happened to me).
The debugging function gst_v4lsrc_palette_name() is still unconditionally
included in the code, but it tries to refer to the array v4l_palette_name[], 
which is conditionally excluded.

This was in the code last time I built the plugins, several releases ago,
though I was too shy to submit a patch.  I'm a bit boggled that nobody
else has run into it!  My 'configure' options are really not strange at all.

The patch comes next.
I've simply returned a dummy name if the array isn't
available.  This is certainly safe, if a bit lazy on my part (ideally I
should check whether I really need the function at all).  However, the
cost of retaining the useless stub is so tiny that I can't be bothered
to see whether removing it breaks anything.
Comment 1 Bernard Leak 2006-02-11 15:00:43 UTC
Created attachment 59139 [details] [review]
Ultra-safe repair for conditionally missing array
Comment 2 Andy Wingo 2006-02-13 09:52:58 UTC
Hi Bernard,

Thanks for the patch. A few things:

(1) gst-plugins 0.8.12 was released recently; can you see if your problem still exists there?

(2) the 0.8 branch is a bit obsolete; can you see if you have this problem with 0.10 as well? The module is gst-plugins-base.

Thanks!
Comment 3 Tim-Philipp Müller 2006-03-22 09:26:09 UTC
Fixed this in 0.8 CVS, was already fixed in 0.10.