After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330684 - Add ability to emit sync-message without messing with the sync handler
Add ability to emit sync-message without messing with the sync handler
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.3
Other Linux
: Normal enhancement
: 0.10.4
Assigned To: Andy Wingo
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-10 15:50 UTC by Andy Wingo
Modified: 2006-02-13 09:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch adding this functionality (6.44 KB, patch)
2006-02-10 15:51 UTC, Andy Wingo 		committed Details | Review

Description Andy Wingo 2006-02-10 15:50:47 UTC 
Apps that want to deal with sync-message currently have to call gst_bus_set_sync_handler (gst_bus_sync_signal_handler, NULL). Aside from being difficult for language bindings, this affects the sync handler, which some other part of the application might have set.

To allow emission of sync-message, I propose two new functions, gst_bus_enable_sync_message_emission, and gst_bus_disable_sync_message_emission. Patch attached.
Comment 1 Andy Wingo 2006-02-10 15:51:55 UTC 
Created attachment 59082 [details] [review]
patch adding this functionality
Comment 2 Andy Wingo 2006-02-13 09:48:37 UTC 
2006-02-10  Andy Wingo  <wingo@pobox.com>

	* gst/gstbus.c (gst_bus_class_init): Declare our private data
	structure.
	(gst_bus_init): Cache the location of the private data in the
	instance structure.
	(gst_bus_enable_sync_message_emission) 
	(gst_bus_disable_sync_message_emission): Implement new public
	functions.
	(gst_bus_post): Emit the sync-message signal if the user asked for
	it. Fixes #330684.

	* gst/gstbus.h (GstBus): Use a padding pointer to cache the
	location of the bus-private structuure.
	(gst_bus_enable_sync_message_emission)
	(gst_bus_disable_sync_message_emission): New public functions.