GNOME Bugzilla – Bug 330682
UI Open with menu disabled
Last modified: 2006-05-31 22:22:55 UTC
Please describe the problem: Grabbed a copy to test all of the changes made in the last few days mcs -debug -out:Search.exe -target:exe ./Category.cs ./ConversationCategory.cs ./Entry.cs ./GroupView.cs ./Panes.cs ./Search.cs ./SortedTileList.cs ./Spinner.cs ./TileCategory.cs ./TypeFilter.cs ./UIManager.cs ./Tiles/ActionMenuItem.cs ./Tiles/Application.cs ./Tiles/Audio.cs ./Tiles/CApplet.cs ./Tiles/Contact.cs ./Tiles/File.cs ./Tiles/Folder.cs ./Tiles/HitFlavor.cs ./Tiles/IMLog.cs ./Tiles/Image.cs ./Tiles/MailMessage.cs ./Tiles/MailAttachment.cs ./Tiles/OpenWithMenu.cs ./Tiles/Presentation.cs ./Tiles/RSSFeed.cs ./Tiles/Spreadsheet.cs ./Tiles/TextDocument.cs ./Tiles/ThumbnailFactory.cs ./Tiles/Tile.cs ./Tiles/TileAction.cs ./Tiles/TileActivator.cs ./Tiles/TileFlat.cs ./Tiles/TileGroup.cs ./Tiles/TileTemplate.cs ./Tiles/Utils.cs ./Tiles/Video.cs ./Tiles/WebHistory.cs ./Tiles/WidgetFu.cs ./Pages/Base.cs ./Pages/NoMatch.cs ./Pages/QuickTips.cs ./Pages/StartDaemon.cs ./Tray/NotificationArea.cs ./Tray/TrayIcon.cs -r:/usr/local/lib/mono/gmime-sharp/gmime-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/pango-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/atk-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/gdk-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/gtk-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/glib-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/gconf-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/gconf-sharp-peditors.dll -r:/usr/lib/mono/gtk-sharp-2.0/gnome-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/art-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/gnome-vfs-sharp.dll -r:/usr/lib/mono/gtk-sharp-2.0/glade-sharp.dll -r:../Util/Util.dll -r:../Util/UiUtil.dll -r:../images/Images.dll -r:../BeagleClient/Beagle.dll -r:Mono.Posix ./Tiles/OpenWithMenu.cs(61,11): error CS0117: `Gnome.Vfs.MimeApplication' does not contain a definition for `SupportsUris' ./Tiles/OpenWithMenu.cs(85,93): error CS0117: `Gnome.Vfs.MimeApplication' does not contain a definition for `Name' Compilation failed: 2 error(s), 0 warnings Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Joe, is it ok to bump the gtk# requirement to 2.7? That is what both banshee and f-spot depend on right now anyway.
Just make sure I can build it on FC5. :) I brought down what I perceived to be the latest libraries. [root@nas bin]# rpm -qa | grep gtk-sharp gtk-sharp2-2.4.0-2.fedora4.novell gtk-sharp2-gapi-2.4.0-2.fedora4.novell [root@nas bin]#
gtk-sharp 2.8 (stable) is out, so I'd rather require that than 2.7 (development version). I'm not sure it's a good idea to do this. For most distros, the latest gtk-sharp available from mono-project.com is 2.4.x, and moving to 2.8 will require gtk+ 2.8 on those distros. What's the functionality needed for? Can we DllImport these ourselves and fall back gracefully?
My view is keep the libraries as easy to meet as possible. I have spent *days* trying to get Beagle running on the new server over just that very issue. Remember, that deployment requires the building of a LOT of other software....wv1, gnumeric, etc. It's not very easy getting all of the pieces to compile on one machine.
Lukas: Ping. I'm putting Beagle into production on Wednesday afternoon and would like to deploy with the new document thumbnails in the lower pane. I can't build from CVS with this issue open. Thanks.
I have disabled the open with menu and removed it from the build until we either bump up the required gtk# or have a reasonable fallback in GnomeFu.
Created attachment 65175 [details] [review] Some configure logic to allow the 'Open With' menu on machines that can support it Ok, I have a kinda hacky configure patch that checks for gtk-sharp 2.8 and enables the open with menu if it is. Don't get me wrong, this isn't perfect, but until we can officially depend on 2.8 (ie. Some more of the 'big boys' start to ship it) its a great way for bleeding edgers to stay that way.
Hey, any thoughts on this anyone? It works for me and is handy (all said and done)
+dnl OpenWith Menu (Requires GTK 2.8) + PKG_CHECK_MODULES(OPEN_WITH, +[ + gtk-sharp-2.0 >= 2.8 +]) This will cause the build to fail if you don't have >= 2.8. You need to specify additional arguments to prevent it from erroring out. The FIXME in the code needs to be removed, but other than that I think it's fine. Do you have a CVS account? If not, can you go through the process of getting one? Info is here: http://developer.gnome.org/doc/policies/accounts/requesting.html
Created attachment 66011 [details] [review] Update Ok, this looks to fix it, if someone without 2.8 could give it a try that would be best, i just tested it by changing the required version to 3.8... Joe: I just sent in the request, depending on the turn around time on the account, if this patch looks good it can be my first commit ;).
Checked this in, thanks.