GNOME Bugzilla – Bug 330645
songs queued in wrong order for audioscrobbler
Last modified: 2006-05-06 21:29:00 UTC
Please describe the problem: Sometimes RB puts the songs in audioscrobbler.queue in wrong order. The result is that last.fm:s spam-protections kicks in and drops those submissions because the timestamp is earlier than on a previous submission. Steps to reproduce: don't know yet.. Actual results: Expected results: Does this happen every time? Other information:
I can confirm this bug, the queue is saved in a wrong order so the spam protection in last.fm kicks in.
*** Bug 336353 has been marked as a duplicate of this bug. ***
I confirm this one too
Can you (anyone) provide any more information on how to reproduce this? I've just had several songs queued over a number of rb restarts, and all were submitted correctly.
I cannot. But the problem appeared when I was online and submission has failed for some reason (maybe last.fm down).
In fact, it happens when you shut down RB with an unsubmited queue. RB will keep the queue to submit it later but it seems that RB will wait until at least one song is played before submitting the forgiven queue. So, the forgiven queue will be submitted later but with an earlier timestamp than the song currently played. I might be wrong but it seems something like that.
Created attachment 64139 [details] [review] patch? I think this accounts for the out of order queue file I had for a while - when a submission fails, the list of submitted entries is in the wrong order, so when we prepend this to the main queue, the queue is no longer in the right order.
I've committed the patch. Please reopen this bug if you experience further problems with out-of-order last.fm submission.
Created attachment 64939 [details] [review] less broken patch in case anyone needs to backport this fix, here's a version of the patch that actually has the right filename in it. (how did I do that?)