After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330525 - Magic values for kind of network in the druid
Magic values for kind of network in the druid
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: general
GIT master
Other All
: Low enhancement
: ---
Assigned To: Snark
Ekiga maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-09 13:51 UTC by Snark
Modified: 2006-05-18 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Should fix the problem (7.98 KB, patch)
2006-04-09 11:19 UTC, Snark
committed Details | Review

Description Snark 2006-02-09 13:51:40 UTC
Report in french, since it was written like this in my mail, and I want it around for myself to care about :

il y a aussi des valeurs magiques dans le druide, pour le type de réseau. Cependant, la valeur est trouvée en regardant le numéro d'ordre d'un choix dans une liste... ce qui me semble fragile. :-/
 
L'idéal serait de pouvoir associer une valeur à chaque item du choix, et
récupérer non pas le numéro d'item, mais cette valeur.
Comment 1 Damien Sandras 2006-02-11 22:01:33 UTC
Fixed
Comment 2 Snark 2006-02-12 08:57:20 UTC
No, it isn't fixed : look at kind_of_net_hack_cb's declaration : there is a nice comment that shows magic values are used.

I do have send a patch for other magic values, but I opened this bug report because I couldn't fix that one yet, and wanted to keep it in sight :-)
Comment 3 Snark 2006-04-09 11:19:39 UTC
Created attachment 63011 [details] [review]
Should fix the problem

Not tested yet, but it compiles ;-)
Comment 4 Snark 2006-05-18 18:37:54 UTC
Updated and tested. Doesn't seem to crash: must be good ;-)