After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330379 - Bogus commits to basesink, basetransform, collectpads
Bogus commits to basesink, basetransform, collectpads
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.3
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-08 11:16 UTC by Andy Wingo
Modified: 2006-06-14 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Andy Wingo 2006-02-08 11:16:26 UTC 
This one needs to be reverted:

2006-02-07  Andy Wingo  <wingo@pobox.com>

	* libs/gst/base/gstcollectpads.c (gst_collect_pads_event) 
	* libs/gst/base/gstbasetransform.c (gst_base_transform_eventfunc): 
	* libs/gst/base/gstbasesink.c (gst_base_sink_configure_segment):
	If we get a new newsegment with a different format, adapt
	accordingly.

Instead, the elements should complain that you can't send a new segment event with a different format from the one that was previously sent.
Comment 1 Thomas Vander Stichele 2006-03-10 17:16:04 UTC 
too late to add now, deferred
Comment 2 Jan Schmidt 2006-03-15 16:58:35 UTC 
ping?
Comment 3 Thomas Vander Stichele 2006-04-22 20:59:50 UTC 
removing milestone since it's not getting handled with any reasonable priority :)
Comment 4 Wim Taymans 2006-06-14 10:31:54 UTC 
        * libs/gst/base/gstbasesink.c: (gst_base_sink_configure_segment),
        (gst_base_sink_preroll_object), (gst_base_sink_get_position):
        * libs/gst/base/gstbasetransform.c:
        (gst_base_transform_sink_eventfunc):
        * libs/gst/base/gstcollectpads.c: (gst_collect_pads_event):
        Don't randomly and silently reset a segment when the format
        changes as this is a bug somewhere upstream. Fixes #330379.