After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330255 - Allow field exist queries on arbitrary fields
Allow field exist queries on arbitrary fields
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.6.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-02-07 11:46 UTC by Ross Burton
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add e_book_query_vcard_field_exists (2.24 KB, patch)
2006-02-07 11:47 UTC, Ross Burton 		rejected Details | Review
Revised patch (4.11 KB, patch)
2006-07-19 14:56 UTC, Ross Burton 		committed Details | Review

Description Ross Burton 2006-02-07 11:46:50 UTC 
e_book_query_field_exists() is great as long as EContact knows about the vCard field the user is trying to check for.  If the field name isn't in the EContactField enum, then they can't use the filters.

Attaching a patch so that you can pass a field name (char*) to be searched for, allowing any vcard fields to be used.
Comment 1 Ross Burton 2006-02-07 11:47:17 UTC 
Created attachment 58853 [details] [review]
Add e_book_query_vcard_field_exists
Comment 2 Sushma Rai 2006-02-08 09:13:09 UTC 
This looks good, but can not be committed now, as it adds a new API
and we are in API freeze mode.
Comment 3 André Klapper 2006-02-09 20:59:29 UTC 
sush: you are always allowed to put the patch status to "accepted-commit_after_freeze". so do i. ;-)
Comment 4 Kjartan Maraas 2006-05-09 11:04:48 UTC 
Can we commit this now?
Comment 5 Ross Burton 2006-05-09 11:12:50 UTC 
That patch is broken, I'll attach a fixed version shortly.
Comment 6 Ross Burton 2006-07-19 14:56:07 UTC 
Created attachment 69178 [details] [review]
Revised patch

This patch actually works (!!).  It adds a new symbol to the query s-expressions, vcard_exists.
Comment 7 Devashish Sharma 2006-07-24 06:30:21 UTC 
The patch looks good, but due to lack of time i cant apply and check if it breaks anything in eds or evolution. can you please check that it doesnt break anything.
Comment 8 Ross Burton 2006-07-24 08:48:45 UTC 
This patch is taken from Maemo 2.0 where it is working well.  It doesn't effect the code path for the existing exists() query, only adds a new path.
Comment 9 Devashish Sharma 2006-07-24 09:23:22 UTC 
ok Ross, commit this.
Comment 10 Ross Burton 2006-07-24 10:22:47 UTC 
Committed to HEAD.