After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330246 - Detaching a tab after reordering the tab will freeze the terminal
Detaching a tab after reordering the tab will freeze the terminal
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
2.13.x
Other All
: Urgent critical
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-07 10:56 UTC by Tony Tsui
Modified: 2006-03-04 06:18 UTC
See Also:
GNOME target: 2.14.x
GNOME version: 2.13/2.14

Attachments
Patch to fix freeze when detaching (975 bytes, patch)
2006-02-07 11:07 UTC, Tony Tsui 		committed Details | Review

Description Tony Tsui 2006-02-07 10:56:11 UTC 
Steps to reproduce:
1. Open two tabs
2. Drag 2nd tab to the far left without releasing the mouse button
3. Move the mouse pointer outside the terminal window as if to detach the tab


Stack trace:


Other information:
Comment 1 Tony Tsui 2006-02-07 11:07:17 UTC 
Created attachment 58851 [details] [review]
Patch to fix freeze when detaching

Hi,

Here is a patch to fix the bug. The freeze was caused by an infinite loop which resulted because the data, "notebook-page", associated with Tab menuitems was not updated before being activated in notebook_tab_selected_callback().

What needs to be done is for the data in Tab menuitems to updated before detaching the tab in notebook_tab_detached_callback().

The patch also removes redundant calls to update_tab_sensitivity() and reset_tab_menuitems() in detach_tab(). These functions have already been called in notebook_tab_removed_callback() after the tab was detached.

Cheers,
Tony
Comment 2 Guilherme de Siqueira Pastore 2006-02-16 19:03:48 UTC 
This is a 2.14 blocker, IMHO. Marking as so.
Comment 3 Guilherme de Siqueira Pastore 2006-03-04 06:18:53 UTC 
This has been committed with some slight changes. Thanks!