After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330181 - shift-enter fails with typeahead popup
shift-enter fails with typeahead popup
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: [obsolete] Type-ahead Find
2.22.x
Other All
: High normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 333914 343572 344453 345111 359844 (view as bug list)
Depends on: 331795
Blocks:
 
 
Reported: 2006-02-06 22:09 UTC by Tuukka Tolvanen
Modified: 2016-11-13 09:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
a trivial fix for the problem. (1.59 KB, patch)
2006-02-19 06:02 UTC, Allison Karlitskaya (desrt) 		needs-work Details | Review

Description Tuukka Tolvanen 2006-02-06 22:09:14 UTC 
Please describe the problem:
with the typeahead entry visible, shift-enter does nothing

Steps to reproduce:
1. open a folder in icon view
2. type beginning of a folder name
3. press shift-enter


Actual results:
nothing

Expected results:
open highlighted target folder and close current folder

Does this happen every time?
yes

Other information:
HEAD 2006-02-07 ~ 2.13.3
worked in 2.12.2 (no typeahead popup)
workaround: esc first
Comment 1 Fabio Bonelli 2006-02-07 10:38:27 UTC 
Easily reproducible, confirming.
Comment 2 Allison Karlitskaya (desrt) 2006-02-19 06:02:39 UTC 
Created attachment 59680 [details] [review]
a trivial fix for the problem.
Comment 3 Allison Karlitskaya (desrt) 2006-02-19 06:03:12 UTC 
elevating priority - this is a patch that should be looked at asap.
Comment 4 Christian Neumair 2006-02-19 12:55:17 UTC 
Thanks for your efforts!

You may want to check for

(event->state & GDK_SHIFT_MASK) == GDK_SHIFT_MASK

instead of just ORing them, and you also forgot to include code for the list view.

As always, maybe you could submit it to the mailing list for review after applying those changes? :)
Comment 5 Allison Karlitskaya (desrt) 2006-02-19 16:55:09 UTC 
crikey!  didn't realise that these were two different things.

if you happen to know the source file for the other it would be appreciated :)
Comment 6 Allison Karlitskaya (desrt) 2006-02-19 17:15:10 UTC 
Right.  So the reason I didn't find the other code is because it lives in gtk+/gtk/gtktreeview.c

In order to add the check for shift+enter I need to be able to get to tree_view->priv->search_window so I can add my own key_press_event hander to it.  I see no way to do this.

BTW: 
/usr/include/gtk-2.0/gdk/gdktypes.h:  GDK_SHIFT_MASK    = 1 << 0,

so my code there is valid (but will be fixed for clarity).
Comment 7 Allison Karlitskaya (desrt) 2006-02-19 17:27:04 UTC 
Filed a GTK bug for some API love.  It doesn't look like this bug will be properly fixable soon.
Comment 8 bill.haneman 2006-02-20 11:12:14 UTC 
WHy was this moved to Accessibility?
Comment 9 Allison Karlitskaya (desrt) 2006-02-20 17:06:23 UTC 
A good question.  It was definitely an accident.
Comment 10 Elijah Newren 2006-06-01 15:59:19 UTC 
*** Bug 333914 has been marked as a duplicate of this bug. ***
Comment 11 Elijah Newren 2006-06-01 15:59:20 UTC 
*** Bug 343572 has been marked as a duplicate of this bug. ***
Comment 12 Elijah Newren 2006-06-10 02:50:46 UTC 
*** Bug 344453 has been marked as a duplicate of this bug. ***
Comment 13 Elijah Newren 2006-06-16 17:29:25 UTC 
*** Bug 345111 has been marked as a duplicate of this bug. ***
Comment 14 Sergej Kotliar 2006-10-05 22:05:28 UTC 
*** Bug 359844 has been marked as a duplicate of this bug. ***
Comment 15 Murray Cumming 2006-10-06 06:38:03 UTC 
Note that alt-downarrow should do the same as enter, and that shift-alt-down should do the same as shift-enter.
Comment 16 Alexandre Franke 2016-11-13 09:41:06 UTC 
Typeahead has been replaced by search which doesn't exhibit this issue.