GNOME Bugzilla – Bug 330175
Reply of messages doesn't check highlight buffer
Last modified: 2007-06-18 03:32:25 UTC
Please describe the problem: A feature was placed in an older version of Evolution whereby if you highlighted text and then hit Reply or Forward only that text would appear in the new message that opened in the composer. 2.5 seems to have lost a check for what exactly is in that buffer. If the message has a few carriage returns at the top, you can actually click that area and highlight it....nothing appears on the screen, BUT that is tripping this code and the composer window opens with nothing in it except the Reply or Forward header. It's confusing carriage returns for text. The code should check to make sure that sane amount of text is in the highlight buffer before it does this. At least a few characters or at least one word or something. I can reproduce this all the time. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
I can confirm that an "invisible selection" will lead to no quoted text when Replying. However, this is not a regression introduced in 2.5.x. I checked using Evo 2.4.2.1. Apparently it has always been like this. Severity minor. Confirming. Personally I'm inclined to consider this a feature rather than a bug. However, I do understand David's arguments. This indeed can be confusing to the user (since he does not see anything selected) and is a usability issue. Adding keyword. Regarding Forwarding: David, does Forwarding act like Replying WRT to selected text in 2.5.x? It does *not* in 2.4.x -- Forwarding always forwards the entire text, even when selecting parts and Forwarding Inline. I definitely think this is the way to go anyway. If Forwarding "supports" selection in 2.5.x I consider this to be a bug, inconsistent WRT the other Forwarding methods and not intended by the Forward action. I even would "volunteer" to file the bug to fix this regression and Forward entire messages only. ;) Adjusting Summary to get rid of the "Forward" part. David, if you do not agree with me, feel free to revert this. :) I believe there was another point I wanted to stress, but apparently I forgot...
quoting comment 0: > The code should check to make sure that sane amount of text is in the > highlight buffer before it does this. At a minimum, at least one visible char needs to be highlighted. Otherwise a regular user doesn't even have a chance to figure out what's going on. :)
This seems like a gtkhtml issue
Agreed with comment 3, moving over to GtkHTML, since it hadn't been moved yet. Note: David verified on IRC that "selective reply" is a feature only when Replying, not on Forwarding.
Ubuntu bug about that: https://launchpad.net/distros/ubuntu/+source/evolution/+bug/18761
Created attachment 89390 [details] [review] proposed evo patch for evolution; added helper function which test selection for non-space characters.
Looks fine to Commit. Ill commit to head and stable
Committed.