After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330125 - _pad_send_event does not check flushing correctly
_pad_send_event does not check flushing correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.2
Other All
: Normal major
: 0.10.4
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-06 14:29 UTC by Wim Taymans
Modified: 2006-02-13 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to check flushing after taking the stream lock (3.62 KB, patch)
2006-02-06 14:31 UTC, Wim Taymans 		accepted-commit_now Details | Review
updated patch (4.07 KB, patch)
2006-02-06 15:07 UTC, Wim Taymans 		accepted-commit_now Details | Review

Description Wim Taymans 2006-02-06 14:29:52 UTC 
gst_pad_send_event does not check the flushing pad flag after grabbing the STREAM_LOCK for serialized events. 

Also the data signal is fired too late, dropping a flush event, for example, would still set the pad to flushing.
Comment 1 Wim Taymans 2006-02-06 14:31:48 UTC 
Created attachment 58805 [details] [review]
patch to check flushing after taking the stream lock
Comment 2 Wim Taymans 2006-02-06 15:07:39 UTC 
Created attachment 58807 [details] [review]
updated patch

updated patch, previous one threw away flush stop events.