After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330089 - [bz2] Wrong mimetype and no typefinding
[bz2] Wrong mimetype and no typefinding
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-06 10:01 UTC by Edward Hervey
Modified: 2006-02-06 18:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes for (1), (2) and (3). (7.69 KB, patch)
2006-02-06 18:15 UTC, Lutz Mueller 		committed Details | Review

Description Edward Hervey 2006-02-06 10:01:44 UTC 
great news, the bz2 plugin has landed in CVS.

But there are a couple of issues.

1/ The plugin uses the "application/x-bz2" mimetype for compressed stream, whereas the gstreamer typefind functions will use the "application/x-bzip" mimetype for bz2 streams.

2/ bz2enc should allow any caps for it's sinkpad

3/ bz2dec should do internal typefinding in order to give the proper caps on it's srcpad (and not application/octet-stream which will never connect to anything when used by decodebin).

For examples of internal typefinding see id3demux.
Comment 1 Andy Wingo 2006-02-06 12:56:44 UTC 
Lutz, could you have a look at these? Feel free to ask if you have questions. We are also available in #gstreamer on freenode.
Comment 2 Lutz Mueller 2006-02-06 18:15:29 UTC 
Created attachment 58818 [details] [review]
Fixes for (1), (2) and (3).
Comment 3 Edward Hervey 2006-02-06 18:25:22 UTC 
you're fast :)

2006-02-06  Lutz Mueller <lutz@topfrose.de>

	Reviewed by: Edward Hervey <edward@fluendo.com>
	
	* ext/bz2/gstbz2enc.c: Accepd "ANY" caps. Use "x-bzip" instead of
	"x-bz2".
	* ext/bz2/gstbz2dec.c: Use "x-bzip" instead of "x-bz2". Initial
	caps are "ANY".
	(gst_bz2dec_chain): Configure the source pad if we can figure out
	the mime type of the decompressed data.
	(gst_bz2dec_[get,set]_property):
	(gst_bz2dec_class_init: New property "first_buffer_size".