GNOME Bugzilla – Bug 329920
Nautilus should act on XF86Back / XF86Forward keys
Last modified: 2007-01-11 19:17:59 UTC
I have my IBM x31 keyboard correctly configured for the back and forward keys, these emit an XF86Back and XF86Forward key events. Nautilus should act on these, and go back or forward as appropriate
How should this apply to spatial windows, if at all?
I doubt this applies to spatial windows, I only think they should work if the currently focused window has back or forward buttons in them (which of course the spatial ones don't)
Created attachment 68680 [details] [review] Proposed patch This patch is based on Epiphany's implementation of extra keybindings. It makes Nautilus react to several XF86XK keybindings. Unfortunately, I have no multimedia keyboard, and XTestFakeKeyEvent didn't like XF86XK_Back and friends, so it remains untested until any of you who is interested in getting this into Nautilus applies the patch and tests as many keybindings as possible.
CCing Philip Langdale <philipl@mail.utexas.edu> who is responsible for the Ephy implementation - maybe you can test it? Updating bug status.
The patch looks correct except that you're asserting that (action != NULL) twice in the key event handler for nautilus_navigation_window. It'll probably be a while before I can actually test it out - hope someone else can step in for that.
Ping.
Great, the patch basically works :) I used nautilus 2.16.3. The patch did not apply cleanly, but that is easy to fix. More importantly, the #ifndef check in src/nautilus-window.c should be replaced by #ifdef. Thanks!
Created attachment 78916 [details] [review] Proposed patch #2 Andreas: Thanks for your testing efforts! I've also submitted this patch to nautilus-list for review: http://mail.gnome.org/archives/nautilus-list/2006-December/msg00109.html
Committed, fixed, closing.