After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329813 - Podcast : some feeds don't work
Podcast : some feeds don't work
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Podcast
0.9.3
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-03 18:09 UTC by Sebastien Bacher
Modified: 2006-03-12 10:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ask for invalid feeds. (1.10 KB, patch)
2006-02-27 13:45 UTC, James "Doc" Livingston
none Details | Review
better patch (3.41 KB, patch)
2006-03-01 12:40 UTC, James "Doc" Livingston
committed Details | Review

Description Sebastien Bacher 2006-02-03 18:09:20 UTC
This bug has been opened on https://launchpad.net/distros/ubuntu/+source/rhythmbox/+bug/30355

"I have subscribed to 3 podcasts from this radio station :
http://www.europe1.fr/podcast/podcast.jsp

RB used to work fine with them, but recently it started refusing to update the feeds, complaining that :

"There was a problem adding this podcast. Please verify the URL: http://www.europe1.fr/podcast/connaissance.jsp"

I tried with another podcast program ("Penguin TV"), just to make sure the feeds are still okay, and they are. So must be RB..."


Could be a gstreamer0.10 bug, feel free to reassign
Comment 1 James "Doc" Livingston 2006-02-04 01:49:32 UTC
That url returns the wrong mime-type (text/html), and PenguinTV is just more lax about what it accepts. Rhythmbox will accept things with the wrong mime-type if they end in ".rss" or ".xml".

I've seen a number of people accidently copy the wrong URL, and try to use the URL of the description page instead of the feed, and this is the best protection against that. Usually Rhythmbox can tell anyway, although there are pages which look enough like an RSS feed to confuse programs.


There are two options:
1) We leave it as is, and mark WONTFIX. Then we complain to the authors that their feed is broken, as it is technically not an RSS feed.

2) We change it to remove the check, which makes the feed work. However this can cause Rhythmbox to get confused if people accidently give the URL of some non-RSS thing.
Comment 2 Mark A. Hershberger 2006-02-16 15:58:04 UTC
1) isn't a good solution.  People will stop using RB's podcast support if other tools work with podcasts that have the wrong mime-typoe.

2) why not attempt to parse what you download?  If it successfully parses as a podcast feed, then use it.  If it doesn't parse, raise an error.
Comment 3 Sebastien Bacher 2006-02-25 16:02:51 UTC
That was probably a gst0.10 bug since it works fine now, feel free to close the bug
Comment 4 James "Doc" Livingston 2006-02-26 13:51:12 UTC
It actually work now because the feed generation script has been fixed, and uses the mime-type text/xml.

It doesn't answer the issue of how far we should go to support non-standard (i.e. broken) feeds.
Comment 5 Sebastien Bacher 2006-02-26 14:01:09 UTC
I think we should not force that against users. Maybe opening a warning dialog in the case the mime-type is uncorrect?
Comment 6 James "Doc" Livingston 2006-02-27 13:45:50 UTC
Created attachment 60235 [details] [review]
ask for invalid feeds.

This makes RB ask when encountering a feed of the wrong mime-type. The wording could be better.
Comment 7 James "Doc" Livingston 2006-03-01 12:40:45 UTC
Created attachment 60392 [details] [review]
better patch

This version doesn't complain about the invalid feed after you tell it that you don't want to load it.
Comment 8 James "Doc" Livingston 2006-03-12 10:46:32 UTC
Patch committed to cvs.