GNOME Bugzilla – Bug 329581
Added 3.5 and 8.5 constraints to Crop
Last modified: 2008-03-26 10:23:15 UTC
I wanted to create some photos that were 3.5" * 8" and 8.5" * 11", and found that F-Spot did not handle this. Therefore I created a small patch and attached it here. Also, please check bug 329174 (http://bugzilla.gnome.org/show_bug.cgi?id=329174) for a possibility to have variable crop, as well as bug 329299 (http://bugzilla.gnome.org/show_bug.cgi?id=329299) for toggling between portrait/landscape while selecting crop area)
Created attachment 58575 [details] [review] Patch diff -u -p -r1.78 PhotoView.cs --- PhotoView.cs 31 Jan 2006 20:05:44 -0000 1.78 +++ PhotoView.cs 2 Feb 2006 10:47:35 -0000 @@ -107,14 +107,21 @@ public class PhotoView : EventBox { private static SelectionConstraint [] constraints = { new SelectionConstraint (Mono.Posix.Catalog.GetString ("No Constraint"), 0.0), + + new SelectionConstraint (Mono.Posix.Catalog.GetString ("3.5 x 5"), 5 / 3.5), new SelectionConstraint (Mono.Posix.Catalog.GetString ("4 x 3 (Book)"), 4.0 / 3.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("4 x 6 (Postcard)"), 6.0 / 4.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("5 x 7 (L, 2L)"), 7.0 / 5.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("8 x 10"), 10.0 / 8.0), + new SelectionConstraint (Mono.Posix.Catalog.GetString ("8.5 x 11"), 11 / 8.5), + + new SelectionConstraint (Mono.Posix.Catalog.GetString ("3.5 x 5 Portrait"), 3.5 / 5), new SelectionConstraint (Mono.Posix.Catalog.GetString ("4 x 3 Portrait (Book)"), 3.0 / 4.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("4 x 6 Portrait (Postcard)"), 4.0 / 6.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("5 x 7 Portrait (L, 2L)"), 5.0 / 7.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("8 x 10 Portrait"), 8.0 / 10.0), + new SelectionConstraint (Mono.Posix.Catalog.GetString ("8.5 x 11 Portrait"), 8.5 / 11), + new SelectionConstraint (Mono.Posix.Catalog.GetString ("Square"), 1.0) };
Any problem with this patch? Since it has not been accepted or reviewed.
I would also suggest following lines: // Film/TV constraints (4:3 is already there) new SelectionConstraint (Mono.Posix.Catalog.GetString ("3:2 (35mm Film/Slide)"), 3.0 / 2.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("16:9 (Widescreen)"), 16.0 / 9.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("3:2 Portrait (35mm Film/Slide)"), 2.0 / 3.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("16:9 Portrait (Widescreen)"), 9.0 / 16.0), // ABC -system new SelectionConstraint (Mono.Posix.Catalog.GetString ("A -system (A4,A5..)"), 1.4142 / 1.0), new SelectionConstraint (Mono.Posix.Catalog.GetString ("A -system Portrait (A4,A5..)"), 1.0 / 1.4142), Additionally very common image sizes are (in centimeters) 10x13, 10x15, 11x15, 11x17, 34x50 and 50x75, some of which are achievable with 4:3 or 2:3 constraint ratio.
Could someone possibly add other suggested ratios and redo the patch before testing could be done?
Created attachment 74743 [details] [review] Some extra ratio constraints Modified the text ----------------- -new ... (Catalog.GetString ("4 x 3 (Book)"), 4.0 / 3.0), +new ... (Catalog.GetString ("4 x 3 (Book, 35mm, Screen)"), 4.0 / 3.0), New ones -------- +new ... (Catalog.GetString ("3.5 x 5"), 5.0 / 3.5), +new ... (Catalog.GetString ("8.5 x 11"), 11.0 / 8.5), +new ... (Catalog.GetString ("16 x 9 (Widescreen)"), 16.0 / 9.0), +new ... (Catalog.GetString ("ISO paper size (A4, A5)"), 1.4142 / 1.0),
*** Bug 332033 has been marked as a duplicate of this bug. ***
4x3 is not 35mm ratio, 2x3 is.
Created attachment 74745 [details] [review] Some extra ratio constraints Ok, hopefully I got it correct this time. I put the 35mm comment to ratio 4 * 6
I thing we now can add some ratios since the list of pre-defined is shorter than ever (auto adapt for portrait/landscape). If you add 16/9 to crop for wallpapers on widescreens, you're wrong. WideScreen computer displays are 16/10 (like in 1920x1200)
Created attachment 74753 [details] [review] Some extra ratio constraints for cropping Ok, hope this one is better...:)
From the foregoing comments, It's not clear to me, if the common cinema 2.391:1 ratio is included. (http://en.wikipedia.org/wiki/Aspect_ratio) If not, this would be very appreciated. I'd like to know, also what happens to this patch. As of version 0.4.0 shipped with Ubuntu Gutsy Gibbon, only the following constraints are available: * 4x3 (book) * 4x6 (postcard) * 5x7 (L, 2L) * 8x10 * square User-defined constraint would be definitely appreciated!
custom ratios added in r3785