After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329575 - misc bugfixes for mad from 0.8
misc bugfixes for mad from 0.8
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-02 10:36 UTC by Jonathan Matthew
Modified: 2006-02-16 10:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
combined patch (3.17 KB, patch)
2006-02-02 10:41 UTC, Jonathan Matthew 		none Details | Review

Description Jonathan Matthew 2006-02-02 10:36:10 UTC 
The fixes for bugs 314771, 308772, 140237, and 302625 haven't been ported to gst-plugins-ugly 0.10.x.
Comment 1 Jonathan Matthew 2006-02-02 10:41:11 UTC 
Created attachment 58574 [details] [review]
combined patch

This contains all the relevant changes from the 0.8 branch.  I've tested the bitrate reporting changes, but I don't know how to test the rest.
Comment 2 Jan Schmidt 2006-02-02 15:44:28 UTC 
Checking the reported duration for some VBR files (in totem or friends) is accurate and not swinging wildly should cover the rest well enough, I think.
Comment 3 Jonathan Matthew 2006-02-15 10:44:18 UTC 
I can't see any problems like that with or without this patch.  I don't have a lot of VBR files, but those I have are handled correctly either way.
Comment 4 Jan Schmidt 2006-02-16 09:54:13 UTC 
Commited, thanks! 

        * ext/mad/gstmad.c: (gst_mad_init), (scale), (gst_mad_update_info),
        (gst_mad_sink_event), (gst_mad_check_caps_reset), (gst_mad_chain),
        (gst_mad_change_state):
          Port fixes for bugs 314771, 308772, 140237, and 302625
          from 0.8 (Patch by Jonathan Matthew, Fixes #329575)
          Use GST_EVENT_FLUSH_STOP to clear data from the current input
          buffer, to avoid using it for any future decoding.