After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329228 - wrong orientation of handles
wrong orientation of handles
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks: 325431
 
 
Reported: 2006-01-30 15:52 UTC by Benjamin Berg
Modified: 2006-03-06 20:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Benjamin Berg 2006-01-30 15:52:40 UTC 
The Handles on the gnome-panel are drawn wrong.

In panel-applet-frame.c the orientations for top/bottom and left/right panels are swapped. It should be GTK_ORIENTATION_VERTICAL for top/bottom and GTK_ORIENTATION_HORIZONTAL for left/right panels.
Comment 1 Vincent Untz 2006-02-12 11:53:11 UTC 
It's a bug in the theme. It works well with the simple theme. What theme are you using?
Comment 2 Benjamin Berg 2006-02-12 14:43:37 UTC 
The Simple theme uses the thinice engine. Which has a workaround for this. It ignores the orientation passed to the drawing function, and decides based on the width/height ration.

From thinice_theme_draw.c:
      orientation = GTK_ORIENTATION_HORIZONTAL;
      if (height > width)
        orientation = GTK_ORIENTATION_VERTICAL;

This is with clearlooks. See bug 325431.
Comment 3 Vincent Untz 2006-02-13 07:33:26 UTC 
Ok, so, it also works with the Raleigh GTK+ theme. Isn't it the default GTK+ theme? Does it also do some guesswork?
Comment 4 Benjamin Berg 2006-02-13 08:27:46 UTC 
The default/Raleigh theme just fills the space with a box and some dots in it. It does not need to check the orientation for this.

Of course the handles are broken in clearlooks. It should never draw them all over the place. But it needs the correct orientation of the handle because it needs to decide the orientation of the lines based on this.
Comment 5 Vincent Untz 2006-03-06 20:19:08 UTC 
Fixed in HEAD.