After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328989 - totem crashes
totem crashes
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.11
Other All
: Normal critical
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-28 17:22 UTC by sergio lenzi
Modified: 2006-04-11 14:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
the algoritm in convolve.c is missing a test before enter the loop... (309 bytes, patch)
2006-01-30 07:02 UTC, sergio lenzi
none Details | Review

Description sergio lenzi 2006-01-28 17:22:33 UTC
Steps to reproduce:
1. select monitor 
2. select monoscope
3. play music


Stack trace:
The module libgstmonoscope has a bug in the
line 235 of convolve.c....

it does not test for correct pointer in data for store to...


correction follows.....


--- gst/monoscope/convolve.c.orig       Sat Jan 28 13:37:11 2006
+++ gst/monoscope/convolve.c    Sat Jan 28 13:37:11 2006
@@ -231,6 +231,8 @@
       double *mid = scratch + size * 4;
       unsigned int i;

+      if (!out)
+       break;
       top++;
       out[size * 2 - 1] = 0;
       for (i = 0; i < size - 1; i++) {


Other information:
Comment 1 Christian Kirbach 2006-01-29 23:22:06 UTC
can you please post a stack trace of the crash? that will enable us to find duplicates.

thanks for suggesting a patch. please attach it to this report so developers can review it.thanks.
Comment 2 sergio lenzi 2006-01-30 07:02:36 UTC
Created attachment 58375 [details] [review]
the algoritm in convolve.c is missing a test before enter the loop...
Comment 3 Andy Wingo 2006-01-31 10:36:06 UTC
Sergio, any chance on getting a stack trace? Run totem under gdb (if you get SIG33 problems, type "handle SIG33 nostop noprint") and do a "thr apply all bt full" when the segfault comes. Thanks!
Comment 4 Christian Kirbach 2006-04-11 14:57:55 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!