After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328956 - Build failure with glibc 2.2
Build failure with glibc 2.2
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: gfloppy
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-28 13:02 UTC by Jens Granseuer
Modified: 2006-01-28 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Reorder includes (385 bytes, patch)
2006-01-28 14:27 UTC, Jens Granseuer 		none Details | Review

Description Jens Granseuer 2006-01-28 13:02:40 UTC 
Current gfloppy doesn't build with glibc 2.2. This is actually a regression of bug 317209. The patch from that bug still applies.
Comment 1 Emmanuele Bassi (:ebassi) 2006-01-28 13:35:51 UTC 
I have just checked HEAD, and the patch in bug #317209 has been correctely applied by Vincent Noel on 2005-09-26.  so, it is present in gnome-utils since 2.13.1.
Comment 2 Jens Granseuer 2006-01-28 14:23:45 UTC 
Well, it's not in the 2.13.5 tarball, however...
Comment 3 Jens Granseuer 2006-01-28 14:27:02 UTC 
Created attachment 58261 [details] [review]
Reorder includes

Urgs, sorry, my fault.

The patch in bug #317209 is against gfloppy.c and has inddeed been applied. I've just encountered the same issue for badblocks.c, though, and assumed it was the same thing. Sorry for the confusion. This is the patch for badblocks.
Comment 4 Emmanuele Bassi (:ebassi) 2006-01-28 14:43:08 UTC 
thanks, fixed in HEAD.  I noticed that src/fdformat.c has the same pattern, so I moved the include for string.h in there too.

feel free to REOPEN this bug in case gfloppy fails to build again.

2006-01-28  Emmanuele Bassi  <ebassi@cvs.gnome.org>

	* src/fdformat.c: re-order includes.

2006-01-28  Emmanuele Bassi  <ebassi@cvs.gnome.org>

	* src/badblocks.c: re-order includes in order to allow compilation
	with glibc 2.2 (patch by Jens Granseuer, closes bug #328956).