GNOME Bugzilla – Bug 328947
About Dialog Crash with German Locale
Last modified: 2006-02-05 08:03:29 UTC
Choosing Help->About with the Windows Regional options set to German crashes dia. Tested using GTK+ 2.6.9 and 2.8.9 The following patch fixes the problem, but of course, it makes it impossible for the translator names actually to show up. --- C:\wc\cvs.gnome.org\dia\app\commands.c Fri Jan 27 22:57:18 2006 +++ C:\wc\cvs.gnome.org\dia\app\commands-fixed.c Fri Jan 27 22:58:23 2006 @@ -631,7 +631,7 @@ "copyright", "(C) 1998-2006 The Free Software Foundation and the authors", "website", "http://www.gnome.org/projects/dia/", "authors", authors, - "documenters", strcmp (translators, "translator_credits-PLEASE_ADD_YOURSELF_HERE") + "documenters", strcmp (translators, _("translator_credits-PLEASE_ADD_YOURSELF_HERE")) ? translators : NULL, "license", license, NULL);
Hi Steffen, nice to meet you again. Some bugs are getting old really fast nowadays ;-) http://cvs.gnome.org/viewcvs/dia/app/commands.c?r1=1.140&r2=1.141 2006-01-27 Hans Breuer <hans@breuer.org> * app/commands.c : respect difference between documenters and translators and show both in about dialog. Closes bug #328711. *** This bug has been marked as a duplicate of 328711 ***
Hans, I'm still having this problem after updating to your latest commands.c source. Please try changing the Windows Regional settings. On my machine for English everything works fine. But if set to German, the crash occurs.
Hi Steffen, the point of the change mentioned above is as follows "authors" is an array of strings, NULL terminated "documentors" is an array of strings, NULL terminated "translators" is a zero terminated string So giving _("translator_credits-PLEASE_ADD_YOURSELF_HERE") to documentors is wrong (probably crashes). Also - if what you have pasted - is the supposed fix it is wrong, too. It not only would it give the wrong kind of value to "documentors" as explained above. Additional it would make the strcmp() always return 0 cause you are comparing equal strings, no matter if they are translated or not. The second bug hiding the first but no "Translated by" page visible. And yes I'v e tested it translated and untranslated :)
Steffen, any chance you are double checking this? As noted above I'm pretty sure this is a build problem.
It's fixed now :-)