After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328919 - Animationplay crashes if a layer is deleted from the image
Animationplay crashes if a layer is deleted from the image
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal normal
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-01-28 00:17 UTC by Michael Schumacher
Modified: 2006-02-14 12:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
avoiding the crash (769 bytes, patch)
2006-01-28 00:18 UTC, Michael Schumacher
needs-work Details | Review

Description Michael Schumacher 2006-01-28 00:17:05 UTC
- open an image that contains multiple layers
- run the animationplay plug-in on it
- while the plug-in dialog is still open, delete a layer from the image
- animationplay will crash when it reaches this layer

Seems like the checks that should handle this are somewhat bogus. IMO it can be improved further, but the patch I'm going to attach will at least avoid the crash, notifies the user with a more or less useful gimp-message and makes the plug-in quit instead. I'd like to know if this causes any other problems.
Comment 1 Michael Schumacher 2006-01-28 00:18:34 UTC
Created attachment 58245 [details] [review]
avoiding the crash
Comment 2 Sven Neumann 2006-01-30 12:15:39 UTC
The message could indeed be improved and it should be marked for translation. Otherwise the change is good and should be applied to both branches. Perhaps you can find a message that is already used in another plug-in so that we don't need to introduce a new translatable string.
Comment 3 Sven Neumann 2006-02-14 12:08:58 UTC
Applied to both branches. String marked for translation in the HEAD branch only.

2006-02-14  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/animationplay.c (render_frame): applied patch
	from Michael Schumacher that fixes a potential crash in the
	plug-in (bug #328919).