After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328815 - [PATCH] Suppress extraneous entries in report heaader
[PATCH] Suppress extraneous entries in report heaader
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Reports
git-master
Other All
: Normal normal
: ---
Assigned To: David Hampton
Chris Lyttle
Depends on:
Blocks:
 
 
Reported: 2006-01-27 10:01 UTC by Christian Stimming
Modified: 2018-06-29 20:56 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Stimming 2006-01-27 10:01:24 UTC
From gnucash-devel, so that we don't forget about it:
https://lists.gnucash.org/pipermail/gnucash-devel/2006-January/015907.html

This is a very minor patch to the "fancy" (Technicolor) stylesheet.  It suppresses extraneous entries table entries in reports when there
are no files specified for the "logo pix" file or the "header pix" file.

Currently empty boxes appear if no files are selected for these entries.
Note: Patch works for both 1.8 series and gnome2 - stylesheets are identical code.


Index: src/report/stylesheets/stylesheet-fancy.scm
===================================================================
--- src/report/stylesheets/stylesheet-fancy.scm    (revision 12305)
+++ src/report/stylesheets/stylesheet-fancy.scm    (working copy)
@@ -289,16 +289,22 @@
        (gnc:html-markup-b
         (gnc:html-document-title doc)))))
     -      (gnc:html-table-set-cell!
-       t 0 0
-       (gnc:make-html-text
-    (gnc:html-markup-img logopixmap)))
+    (if (and logopixmap
+         (not (string=? logopixmap "")))
+          ;; check for logo image file name non blank
+      (gnc:html-table-set-cell!
+        t 0 0
+          (gnc:make-html-text
+       (gnc:html-markup-img logopixmap))) )
+;     +    (if (and headpixmap
+         (not (string=? headpixmap "")))
+          ;; check for header image file name nonblank
+      (gnc:html-table-set-cell!
+        t 0 1
+      (gnc:make-html-text
+       (gnc:html-markup-img headpixmap))) )
     -      (gnc:html-table-set-cell!
-       t 0 1
-       (gnc:make-html-text
-    (gnc:html-markup-img headpixmap)))
-           (apply
       gnc:html-table-set-cell!
       t 2 1
@@ -308,8 +314,7 @@
    ssdoc))

(gnc:define-html-style-sheet
- 'version 1
- 'name (N_ "Fancy")
+ 'version 1.01 'name (N_ "Fancy")
 'renderer fancy-renderer
 'options-generator fancy-options)
Comment 1 David Hampton 2006-01-30 01:56:58 UTC
Applied.
Comment 2 John Ralls 2018-06-29 20:56:12 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=328815. Please update any external references or bookmarks.