GNOME Bugzilla – Bug 328632
pangoatsui-fontmap.c fails to compile
Last modified: 2006-01-26 22:16:42 UTC
pangoatsui-fontmap.c fails to compile on 10.4.4 The error message is... pangoatsui-fontmap.c: In function 'pango_atsui_family_class_init': pangoatsui-fontmap.c:183: error: 'i' undeclared (first use in this function) pangoatsui-fontmap.c:183: error: (Each undeclared identifier is reported only once pangoatsui-fontmap.c:183: error: for each function it appears in.) pangoatsui-fontmap.c:183: error: '_pango_included_atsui_modules' undeclared (first use in this function) pangoatsui-fontmap.c:184: warning: implicit declaration of function 'pango_module_register' make[4]: *** [libpangocairo_1_0_la-pangoatsui-fontmap.lo] Error 1 It's clearly due to wrong code, in the first error the 'i' is not defined in the function at all and hopefully it isn't a global variable :-).
Thanks. Fixed now. I blame it on the author of the ATSUI stuff who was not responsing. So I had to change the code, but don't have one of those expensive Apple machine :). 2006-01-25 Behdad Esfahbod <behdad@gnome.org> * pango/pangoatsui-fontmap.c (pango_atsui_family_class_init): Declare int i! (bug #328632)
It fixes one of the errors but there are still others. I've reopened the bug, is that the right thing to do or should it be a new one ? The error message now is... pangoatsui-fontmap.c: In function 'pango_atsui_family_class_init': pangoatsui-fontmap.c:184: error: '_pango_included_atsui_modules' undeclared (first use in this function) pangoatsui-fontmap.c:184: error: (Each undeclared identifier is reported only once pangoatsui-fontmap.c:184: error: for each function it appears in.) pangoatsui-fontmap.c:185: warning: implicit declaration of function 'pango_module_register' _pango_included_atsui_modules is of type PangoIncludedModule. Is that a missing entry from momdules.h, that's where the others are declared ? pango_module_register is defined in pango-modules.h or I guess that should be #include'd Dave
Sorry I overlooked the other one. Should be fixed now. Please test and reopen again if needed... 2006-01-26 Behdad Esfahbod <behdad@gnome.org> * pango/modules.h, pango/Makefile.am: Fix more ATSUI stuff in build infrastructure. Sigh... (bug #328632)
One last change I think pangoatsui-fontmap.c requires a #include "modules.h" at least that makes it compile here, there may be a better header.
Ah, this one I knew, but missed again! That's why I fixed modules.h after all... If you have had opened new bugs for each issue, I have been a real bugzilla hero by now :). Thanks for testing btw. 2006-01-26 Behdad Esfahbod <behdad@gnome.org> * pango/pangoatsui-fontmap.c: #include <modules.h>. (bug #328632)
Yep, that's done the trick. Thanks for the fixing. Dave