After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328617 - Should not include -DG_DISABLE_DEPRECATED unconditionally
Should not include -DG_DISABLE_DEPRECATED unconditionally
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-01-25 17:24 UTC by Behdad Esfahbod
Modified: 2006-01-29 04:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pango patch (9.23 KB, patch)
2006-01-25 19:33 UTC, Behdad Esfahbod 		committed Details | Review
Gtk+ patch (9.60 KB, patch)
2006-01-25 19:55 UTC, Behdad Esfahbod 		committed Details | Review

Description Behdad Esfahbod 2006-01-25 17:24:30 UTC 
Currently both Pango and Gtk+ use -DG_DISABLE_DEPRECATED, but this bites us in the future when an interface we are currently using is deprecated in a future version of glib.  This happened with Gtk+ when glib got g_slice and deprecated memchunks.  That's bad.

As a solution, -DG_DISABLE_DEPRECATED should only be used if the major-minor of the found glib is the same as the major-minor of the required glib.
Comment 1 Behdad Esfahbod 2006-01-25 19:33:24 UTC 
Created attachment 58118 [details] [review]
pango patch

2006-01-25  Behdad Esfahbod  <behdad@gnome.org>

        * configure.in: If major.minor of required and available glib versions
        are the same, add -DG_DISABLE_DEPRECATED to GLIB_CFLAGS. (bug #328617)

        * */Makefile.am: Remove hardcoded -DG_DISABLE_DEPRECATED.
Comment 2 Behdad Esfahbod 2006-01-25 19:55:12 UTC 
Created attachment 58119 [details] [review]
Gtk+ patch

Matthias, commit-now?

I suggest it on stable branch too.
Comment 3 Behdad Esfahbod 2006-01-28 19:03:47 UTC 
Matthias: ping.
Comment 4 Matthias Clasen 2006-01-29 03:44:20 UTC 
Looks good to me.
Comment 5 Behdad Esfahbod 2006-01-29 04:00:21 UTC 
Committed to Gtk+ HEAD.  Branch too?

2006-01-28  Behdad Esfahbod  <behdad@gnome.org>

        * configure.in: If major.minor of required and available glib versions
        are the same, add -DG_DISABLE_DEPRECATED to GLIB_CFLAGS. (bug #328617)

        * */Makefile.am: Remove hardcoded -DG_DISABLE_DEPRECATED.