After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328610 - GtkEntry completion tries to block invalid signals if popup-completion is FALSE
GtkEntry completion tries to block invalid signals if popup-completion is FALSE
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.8.x
Other FreeBSD
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-01-25 16:46 UTC by Benedikt Meurer
Modified: 2006-01-25 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Suggested fix (3.53 KB, patch)
2006-01-25 16:48 UTC, Benedikt Meurer 		none Details | Review

Description Benedikt Meurer 2006-01-25 16:46:52 UTC 
In GtkEntry the changed_id and insert_text_id signals aren't reset properly when the popup-completion/inline-completion properties are changed to FALSE. And the code tries to block/unblock the changed_id signal several times, no matter if it's connected or not.
Comment 1 Benedikt Meurer 2006-01-25 16:48:18 UTC 
Created attachment 58106 [details] [review]
Suggested fix

This patch fixes the problem for gtk+ HEAD, but the bug is also present in Gtk+ 2.8 (patch should also apply, but didn't check).
Comment 2 Matthias Clasen 2006-01-25 19:02:53 UTC 
This should fix it

2006-01-25  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkentrycompletion.c: 
	* gtk/gtkentry.c: Be more careful when blocking signals.