After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328489 - Bookmark search should be on urls and titles
Bookmark search should be on urls and titles
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
git master
Other All
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 420058 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-24 21:05 UTC by Corey Burger
Modified: 2008-05-30 19:26 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
20080520_bgo_328489_search-in-urls: proposed fix (699 bytes, patch)
2008-05-20 20:05 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Corey Burger 2006-01-24 21:05:27 UTC 
Please describe the problem:
Currently bookmark search is only on titles, not urls as well. This can observed
in the following way:



Steps to reproduce:
1. Bookmark the Linux Game Tome.
2. Observe the url of www.happypenguin.org
3. Type in 'hap' in the url bar and fail to see the bookmark
4. Type in 'game' and see the bookmark

Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Peter Harvey 2006-01-24 21:09:21 UTC 
This is a good example of why bookmarks and history should be conceptually merged. But to fix this in the current lease would be a bit hack-ish I think. We'll target for next release.
Comment 2 Reinout van Schouwen 2007-03-19 10:36:30 UTC 
*** Bug 420058 has been marked as a duplicate of this bug. ***
Comment 3 Reinout van Schouwen 2007-05-31 22:52:38 UTC 
The current Summer of Code project will touch upon this.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2008-05-20 20:05:01 UTC 
Created attachment 111254 [details] [review]
20080520_bgo_328489_search-in-urls: proposed fix

Simple fix.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2008-05-30 19:11:51 UTC 
Committed to trunk. -22 also?
Comment 6 Christian Persch 2008-05-30 19:26:08 UTC 
Yes, please.