GNOME Bugzilla – Bug 328245
Give versions better default names
Last modified: 2018-07-12 00:12:08 UTC
When the user modifies a photo, better default names could be given. For instance, if they cropped the photo to an 8x10, the name could be "Cropped to 8 x 10", or if the user pressed the Sepia button, it could say "Sepia".
*** Bug 328244 has been marked as a duplicate of this bug. ***
Very nice idea
Created attachment 59472 [details] [review] Patch agains CVS ls IMG_0369 (Adjusted color).JPG IMG_0369 (B&W).JPG IMG_0369 (Cropped (8 x 10)).JPG IMG_0369 (Cropped (No Constraint)).JPG IMG_0369 (Cropped (Square)(2)).JPG IMG_0369 (Cropped (Square)).JPG IMG_0369.JPG IMG_0369 (Modified in GIMP Image Editor).JPG IMG_0369 (Removed redeye).JPG IMG_0369 (Sepia).JPG
Any problem with accepting this one to CVS? If so, what problem? No comments at all since mid feb when I submitted it.
I'm a little worried that the names would quickly grow out of control and i'm not sure that the last edit operation you did on an image is something you really want in the name. I'll keep thinging about it though.
Must be better than (1) or (2) though. Yes, not that anonymous, but much easier for humans to find a picture. Not always we are using only F-Spot to find the pictures.
Quick patch review... - no longer apply cleanly against CVS - the idea sounds great!. Larry, keeping the number of version name low is one thing, but having a more accurate default as version name is *highly* valuable ! - I don't like much the way it's implemented. One different way for each 'Edit' capability. But it's probably the 'fault' of the not-so-good implementation of the Edit code...
Created attachment 67045 [details] [review] updated patch against CVS An updated patch that patches cleanly against CVS. I have only verified against a linked photo, since nfs seems to disable the icons for modifying the photo. (But copy and Edit -> Color adjust works fine (and gets the new sane version name, so the patch should work fine)
Would it be possible to expose the version name generation in a way that it can be overridden by extensions? This would be exactly what I need.
Review of attachment 67045 [details] [review]: comment #9 should be the proper way to do that...
I use Ulf's exiflow extensions, and I think this definitely needs to happen. If we can't build custom version naming into the main program preferences, please at least expose it to extensions.
F-Spot has moved to https://github.com/f-spot/f-spot/issues If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub. Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.