After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328161 - snippets: use CDATA in XML instead of escaping every <, > character
snippets: use CDATA in XML instead of escaping every <, > character
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
git master
Other All
: Low minor
: 2.14.0
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-22 13:24 UTC by Jeroen Zwartepoorte
Modified: 2019-03-23 21:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Nice xml output (3.78 KB, patch)
2006-03-19 18:41 UTC, jessevdk@gmail.com 		committed Details | Review

Description Jeroen Zwartepoorte 2006-01-22 13:24:34 UTC 
This makes the snippets readable when viewing the XML directly.

I assume this needs to be done in Snippet.py, but i don't understand python to do it myself.
Comment 1 jessevdk@gmail.com 2006-02-13 21:38:42 UTC 
The system wide files are now well formatted (from indentation point of view as well as CDATA. The text and accelerator nodes are now CDATA).

The usersnippets are not so well formatted. This is caused by the write method of ElementTree which snippets now uses. I'll look into writing a custom write method which does indentation and CDATA.
Comment 2 jessevdk@gmail.com 2006-03-19 18:41:42 UTC 
Created attachment 61562 [details] [review]
Nice xml output

This patch adds a custom xml writer to snippets so that the user xml files can also have a nice format (2 space indentation, correct use of newline).
Comment 3 Paolo Borelli 2006-03-19 18:48:47 UTC 
the patch looks ok to me (not reviewed in detail), but I think we should wait after the branch. I am marking it commit-after-freeze (not sure if it's the right status, but it will do for now)
Comment 4 jessevdk@gmail.com 2006-04-22 12:53:53 UTC 
Committed to CVS HEAD.