After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328144 - Remove from trash confirmation alert should use WARNING icon, not QUESTION
Remove from trash confirmation alert should use WARNING icon, not QUESTION
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
0.x.x [obsolete]
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-22 10:44 UTC by Luca Ferretti
Modified: 2006-01-26 22:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
The patch (1.68 KB, patch)
2006-01-26 08:15 UTC, Luca Ferretti
none Details | Review

Description Luca Ferretti 2006-01-22 10:44:13 UTC
Please describe the problem:
As per HIG, confirmation alers should use WARNING icon, not QUESTION.

Moreover please note that currently both empty trash confirmation alert and
direct delete confirmation alert are using WARNING icon

Steps to reproduce:
1. Move a file to trash and open trash://
2. Select a file
3. Press Ctrl+T (or select relevant menu entry)


Actual results:
The confirmation alert show a QUESTION icon

Expected results:
The confirmation alert show a WARNING icon

Does this happen every time?
Yes

Other information:
Comment 1 Luca Ferretti 2006-01-26 08:15:04 UTC
Created attachment 58140 [details] [review]
The patch

Based on similar change by Dennis Cranston on Delete confirmation alert (2005-11-24)
Comment 2 Martin Wehner 2006-01-26 22:21:40 UTC
Committed, thanks.

2006-01-26  Martin Wehner  <martin.wehner@gmail.com>

	* src/file-manager/fm-directory-view.c:
	(confirm_delete_from_trash):
	HIGify the icon in the delete from trash dialog.
	Patch from Luca Ferretti <elle.uca@libero.it>