After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327959 - Nothing happens if you left click on the icon
Nothing happens if you left click on the icon
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-manager
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-01-21 11:12 UTC by Richard Hughes
Modified: 2006-01-24 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
initial patch (721 bytes, patch)
2006-01-21 11:13 UTC, Richard Hughes
needs-work Details | Review
patch (1.83 KB, patch)
2006-01-23 20:32 UTC, William Jon McCann
committed Details | Review

Description Richard Hughes 2006-01-21 11:12:04 UTC
Found from http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178118

Comment from Christopher Aillon (caillon@redhat.com)  on 2006-01-18
... it should launch the [preferences] menu, like R click does....
Comment 1 Richard Hughes 2006-01-21 11:13:43 UTC
Created attachment 57783 [details] [review]
initial patch

Initial patch, probably wrong. If you double click, then three instances of g-p-p appear, which is definatly wrong.
This page is useful: http://developer.gimp.org/api/2.0/gdk/gdk-Event-Structures.html
Comment 2 Christopher Aillon 2006-01-21 17:06:13 UTC
Uh, the menu != gnome-power-prefs.  You know, the one with suspend, hibernate, etc. like what happens when you R click.
Comment 3 Christopher Aillon 2006-01-21 17:17:42 UTC
But I also think that double click should no longer do anything.  The user will be able to access the prefs from the menu
Comment 4 Richard Hughes 2006-01-21 17:19:19 UTC
Okay, gotcha. Jon, Jaap, this sound okay?
Comment 5 William Jon McCann 2006-01-21 18:03:27 UTC
Sounds right to me.
Comment 6 Richard Hughes 2006-01-21 18:09:22 UTC
Shouldn't the menu's be different, e.g. left button has Hibernate, Suspend, while right has Preference, Help, About?
Comment 7 Jaap A. Haitsma 2006-01-22 20:12:54 UTC
I'm ok if we rip that double click behaviour opens power preferences, but it doesn't really hurt either to have it. It's something that users might discover by reading the help (when we put it in there).

Splitting up the menu over right and left click sounds wrong to me. How do I know which one I should use.

Furthermore I don't know of any applet that shows a menu on left click.


Comment 8 William Jon McCann 2006-01-23 20:32:38 UTC
Created attachment 57962 [details] [review]
patch

I'm don't think there are enough things in the menu to justify a different right and left click menu.  Ok to commit?
Comment 9 Richard Hughes 2006-01-24 17:42:50 UTC
Okay, agreed. Go for it Jon, good to commit. Thanks.