GNOME Bugzilla – Bug 327925
Yukon one suit
Last modified: 2021-06-02 11:31:44 UTC
Yukon one suit to follow. The usual heavily commented code to follow. (No docs yet, but all that really needs to be said is it is a one suit version of Yukon which makes it much easier to solve, a matter of skill.)
Created attachment 57764 [details] [review] Yukon One Suit
Just a quick comment: I've had a look at it, but not tried playing it yet. There is a little work needed to make it work on post 2.11 aisleriot (to do with the new droppable stuff and the way it is hooked into the button-release code). That shouldn't be too hard for me to do, but since it is obviously too late for 2.14 its not a high priority.
I've play tested it quite a bit (otherwise I wouldn't have noticed the glaring error which prevented me from placing black on black, ooops). I really hope most of the code can be backported. (make standard one suit deck to sol.scm and the layout cleanup and make-deck abstraction to yukon.scm) Given how much extra work my inability to work with CVS Head causes I'm certainly willing to be patient and wait. It is the major releases I'm really interested in so as you have already pointed out there isn't any hurry (although with any luck by the time 2.1 comes we'll have >100 games in Aisleriot!).
What kind of documentation would you like me to provide for this? I'd like to avoid repeating too much of the documentation from Yukon. let me know what you would like to see and I will try to tackle this soon.
Comment on attachment 57764 [details] [review] Yukon One Suit For what it's worth, I've been working on adding this game, but it's a reset. Most of your code work was refactoring that really belongs in yukon.scm instead, and the rest needed adjustments since we've added droppable highlighting... The kicker is that it would have been defective anyway, since the patch above contains no modification for game-over detection and hints, which is where the all of the real fun happens. :) I'm seeing a another bug somewhere higher in the stack, so while I may have code that does this game correctly now, I'm not ready to upload it yet.
Re-assigning to default owner.
I think that this should be either an option on yukon, or at least make the yukon code so flexible that this can be simply (primitive-load-path "yukon") and then settings some variables differently. Also, needs the help written. No update here in years, is anyone still really interested in this variant?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/aisleriot/-/issues/68.