After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327749 - Empty custom command entries when predefined app is selected
Empty custom command entries when predefined app is selected
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
git master
Other Linux
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-19 20:29 UTC by Luca Cavalli
Modified: 2006-01-30 00:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
preferred-apps-keep-custom-entries.patch (10.43 KB, patch)
2006-01-19 20:33 UTC, Luca Cavalli 		accepted-commit_now Details | Review

Description Luca Cavalli 2006-01-19 20:29:01 UTC 
When a predefined application is selected from the list, custom command entries are disabled and cleared. It would be better if they were only disabled, thus showing selected application command and options. This features was present in the "old" applet and was requested by Sebastien on IRC (iirc). For some reason it was not present in the tarball used for the CVS import. Note that applying this patch will make current applet suffering from bug #116129, but at the moment there isn't a simple solution (see also comment #3).
Comment 1 Luca Cavalli 2006-01-19 20:33:15 UTC 
Created attachment 57670 [details] [review]
preferred-apps-keep-custom-entries.patch
Comment 2 Sebastien Bacher 2006-01-22 22:21:03 UTC 
Thanks for your patch, feel free to commit it
Comment 3 Luca Cavalli 2006-01-22 22:47:56 UTC 
Sebastien, I would be happy to commit the patch, but I haven't cvs account. Could you do it for me, please? Thanks.
Comment 4 Rodrigo Moya 2006-01-28 15:27:22 UTC 
committed, thanks
Comment 5 Christian Persch 2006-01-28 16:02:50 UTC 
The entry shows the text now, but it's insensitive. HIG recommends entries not to be insensitive, just disabled (no input), so you can still c&p...
Comment 6 Rodrigo Moya 2006-01-28 18:47:13 UTC 
Ok, fixed the sensitivity/disabling thing
Comment 7 Luca Cavalli 2006-01-30 00:23:09 UTC 
IMHO, I think that making a text entry just not editable may be misleading for the user, since there are no visual effect marking its state, since "not editable" and "editable" are rendered the same way, at least with all the themes I tested.