GNOME Bugzilla – Bug 327702
Less eternal find highlight
Last modified: 2006-03-24 11:55:18 UTC
Although the new find highlight feature is wonderful, it can get a bit annoying that it is never removed. Perhaps it should be removed when closing the dialog or after a timeout? Other information:
you can remove it by pressing ctrl+shift+K, but I agree that it should be more discoverable hw to get rid of the highlighting.
What about adding a "Highlight" menu item in the search menu like the "Highlight" button in the firefox find bar? Or a "Clear Highlights" menu item?
That still feels a bit far off. How about using the new firefox-esque notify bar? (does it have an official name?)
This problem was discuessed also in the ui-review. pbor: could you please attach the relevant bit from the log (I don't have access to it now)?
(18:54:18) <joachim> all terms in yellow? nice! (18:54:32) <pbor> until gtk gets support for symbolic colors (18:54:34) <joachim> but how do I clear it? (18:54:46) <pbor> joachim: ctrl+shift+K (18:54:46) <calum> heh, I was just wondering that :) (18:54:59) <pbor> yeah, that's what I wanted to ask :) (18:55:00) <calum> is that option on the menus anywhere? (18:55:02) <joachim> no menu item? (18:55:23) <joachim> Could you add Search -> Clear highlight ? (18:55:32) <calum> sounds good to me... (18:55:40) <pbor> yes, that's a possibility (18:56:12) <pbor> the other possibility would be to clear the hl when closing the dialog (18:56:42) <pbor> but it would make the hl less useful if one wants to keep stuff highlighted (18:56:48) <calum> yeah... I wonder if there's much point in having the highlight at all if you're going to do that...
Created attachment 60066 [details] [review] Search -> Clear highlight menu entry This patch adds a Clear Highlight menu entry in the search menu.
Created attachment 60067 [details] [review] Menu entry + sensitivity Same as before, but it handles the menu sensitivity. Also, help string is now understandable by an english speaker now ;-)
Created attachment 60068 [details] [review] Menu entry + sensitivity Sorry last one was the wrong file
I committed the patch, though I had to change the accel back to ctrl+shift+K despite my suggestion on irc: ctrl+shift+F triggers unicode insertion here (ctrl+shift+K is not affected since K is not an exadecimal number).
ops, sorry Steve, I told you I would have let you close the bug to test your brand new bugzilla account, but I forgot... oh well, next time.
Happen again with 2.14.0.1
in fact that's the way it's supposed to work, closing again