After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327702 - Less eternal find highlight
Less eternal find highlight
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
2.14.x
Other All
: Normal minor
: 2.14.0
Assigned To: Steve Frécinaux
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-19 13:33 UTC by Pierre Ossman
Modified: 2006-03-24 11:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Search -> Clear highlight menu entry (3.69 KB, patch)
2006-02-24 15:47 UTC, Steve Frécinaux
none Details | Review
Menu entry + sensitivity (3.69 KB, patch)
2006-02-24 16:11 UTC, Steve Frécinaux
none Details | Review
Menu entry + sensitivity (6.08 KB, patch)
2006-02-24 16:15 UTC, Steve Frécinaux
committed Details | Review

Description Pierre Ossman 2006-01-19 13:33:42 UTC
Although the new find highlight feature is wonderful, it can get a bit annoying
that it is never removed. Perhaps it should be removed when closing the dialog
or after a timeout?

Other information:
Comment 1 Paolo Borelli 2006-01-19 13:37:02 UTC
you can remove it by pressing ctrl+shift+K, but I agree that it should be more discoverable hw to get rid of the highlighting.

Comment 2 Paolo Maggi 2006-01-19 13:49:53 UTC
What about adding a "Highlight" menu item in the search menu like the "Highlight" button in the firefox find bar?
Or a "Clear Highlights" menu item?
Comment 3 Pierre Ossman 2006-01-19 13:57:22 UTC
That still feels a bit far off. How about using the new firefox-esque notify bar? (does it have an official name?)
Comment 4 Paolo Maggi 2006-02-22 16:39:24 UTC
This problem was discuessed also in the ui-review.
pbor: could you please attach the relevant bit from the log (I don't have access to it now)?
Comment 5 Paolo Borelli 2006-02-22 16:58:08 UTC
(18:54:18) <joachim> all terms in yellow? nice!
(18:54:32) <pbor> until gtk gets support for symbolic colors
(18:54:34) <joachim> but how do I clear it?
(18:54:46) <pbor> joachim: ctrl+shift+K
(18:54:46) <calum> heh, I was just wondering that :)
(18:54:59) <pbor> yeah, that's what I wanted to ask :)
(18:55:00) <calum> is that option on the menus anywhere?
(18:55:02) <joachim> no menu item?
(18:55:23) <joachim> Could you add Search -> Clear highlight ?
(18:55:32) <calum> sounds good to me...
(18:55:40) <pbor> yes, that's a possibility
(18:56:12) <pbor> the other possibility would be to clear the hl when closing the dialog
(18:56:42) <pbor> but it would make the hl less useful if one wants to keep stuff highlighted
(18:56:48) <calum> yeah... I wonder if there's much point in having the highlight at all if you're going to do that...
Comment 6 Steve Frécinaux 2006-02-24 15:47:31 UTC
Created attachment 60066 [details] [review]
Search -> Clear highlight menu entry

This patch adds a Clear Highlight menu entry in the search menu.
Comment 7 Steve Frécinaux 2006-02-24 16:11:56 UTC
Created attachment 60067 [details] [review]
Menu entry + sensitivity

Same as before, but it handles the menu sensitivity. Also, help string is now understandable by an english speaker now ;-)
Comment 8 Steve Frécinaux 2006-02-24 16:15:50 UTC
Created attachment 60068 [details] [review]
Menu entry + sensitivity

Sorry last one was the wrong file
Comment 9 Paolo Borelli 2006-02-25 01:13:28 UTC
I committed the patch, though I had to change the accel back to ctrl+shift+K despite my suggestion on irc: ctrl+shift+F triggers unicode insertion here (ctrl+shift+K is not affected since K is not an exadecimal number).
Comment 10 Paolo Borelli 2006-02-25 01:15:17 UTC
ops, sorry Steve, I told you I would have let you close the bug to test your brand new bugzilla account, but I forgot... oh well, next time.
Comment 11 Sebastien Bacher 2006-03-24 11:39:48 UTC
Happen again with 2.14.0.1
Comment 12 Sebastien Bacher 2006-03-24 11:55:18 UTC
in fact that's the way it's supposed to work, closing again