After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327518 - Port to goption command line parsing
Port to goption command line parsing
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 327986 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-18 11:43 UTC by Luca Ferretti
Modified: 2006-05-13 04:54 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Patch to make evince use goption instead of popt (2.93 KB, patch)
2006-03-24 18:27 UTC, Michael Plump
committed Details | Review

Description Luca Ferretti 2006-01-18 11:43:08 UTC
Please describe the problem:
The build process fails showing the following message.

Steps to reproduce:
1. well, use jhbuild to build your test installation of GNOME under /opt/gnome2 :-)

Actual results:
if gcc -DHAVE_CONFIG_H -I. -I. -I.. -DDATADIR=\"/opt/gnome2/share/evince\"
-DGNOMEDATADIR=\"/opt/gnome2/share\" -I../lib -I../cut-n-paste/recent-files/
-I../cut-n-paste/zoom-control/ -I../cut-n-paste/toolbar-editor/ -I../backend
-I../properties -DGNOMELOCALEDIR=\"/opt/gnome2/share/locale\"
-DGNOMEICONDIR=\""/opt/gnome2/share/pixmaps"\" -DORBIT2=1 -pthread
-I/opt/gnome2/include/gtk-2.0 -I/opt/gnome2/lib/gtk-2.0/include
-I/opt/gnome2/include/atk-1.0 -I/opt/gnome2/include/cairo
-I/opt/gnome2/include/pango-1.0 -I/opt/gnome2/include/glib-2.0
-I/opt/gnome2/lib/glib-2.0/include -I/opt/gnome2/include/libgnomeui-2.0
-I/opt/gnome2/include/libgnome-2.0 -I/opt/gnome2/include/libgnomecanvas-2.0
-I/opt/gnome2/include/libart-2.0 -I/opt/gnome2/include/gconf/2
-I/opt/gnome2/include/libbonoboui-2.0 -I/opt/gnome2/include/gnome-vfs-2.0
-I/opt/gnome2/lib/gnome-vfs-2.0/include -I/opt/gnome2/include/gnome-keyring-1
-I/opt/gnome2/include/orbit-2.0 -I/opt/gnome2/include/libbonobo-2.0
-I/opt/gnome2/include/bonobo-activation-2.0 -I/opt/gnome2/include
-I/usr/include/freetype2 -I/opt/gnome2/include/libxml2
-I/opt/gnome2/include/libgnomeprint-2.2
-I/opt/gnome2/include/libgnomeprintui-2.2 -I/opt/gnome2/include/libglade-2.0
-I/opt/gnome2/include/poppler/glib -I/opt/gnome2/include/poppler  
-I/opt/gnome2/include/dbus-1.0 -I/opt/gnome2/lib/dbus-1.0/include
-I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib/glib-2.0/include   -Wall
-Wmissing-prototypes  -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED
-DGTK_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -DPANGO_DISABLE_DEPRECATED
-DBONOBO_DISABLE_DEPRECATED    -g -O2 -MT main.o -MD -MP -MF ".deps/main.Tpo" -c
-o main.o main.c; \
then mv -f ".deps/main.Tpo" ".deps/main.Po"; else rm -f ".deps/main.Tpo"; exit 1; fi
main.c: In function ‘main’:
main.c:258: error: ‘GNOME_PARAM_POPT_TABLE’ undeclared (first use in this function)
main.c:258: error: (Each undeclared identifier is reported only once
main.c:258: error: for each function it appears in.)
main.c:263: error: ‘GNOME_PARAM_POPT_CONTEXT’ undeclared (first use in this
function)
make[3]: *** [main.o] Error 1
make[3]: Leaving directory `/test/cvs/gnome2/evince/shell'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/test/cvs/gnome2/evince/shell'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/test/cvs/gnome2/evince'
make: *** [all] Error 2


Expected results:


Does this happen every time?


Other information:
There was a big switch against popt stuff in libgnome[ui] and libbonobo[ui] in
the latest day. Maybe it could be a non-evince issue
Comment 1 Christian Persch 2006-01-18 12:17:58 UTC
main.c should #undef GNOME_DISABLE_DEPRECATED, or port to goption argument parsing (making evince depend on libgnome >= 2.13.7).
Comment 2 Nickolay V. Shmyrev 2006-01-19 22:03:59 UTC
I think it's not the time to bump requirements. I have removed disable deprecated. Leaving this bug as a reminder.
Comment 3 Luca Ferretti 2006-01-20 13:12:29 UTC
OK to change bug summary in "Port to goption command line parsing" ?
Comment 4 Nickolay V. Shmyrev 2006-01-20 15:07:04 UTC
Sure. I am going to do it after FC5 will out. After that we can bump libgnome and gtk requirements
Comment 5 Nickolay V. Shmyrev 2006-01-21 15:37:39 UTC
*** Bug 327986 has been marked as a duplicate of this bug. ***
Comment 6 Michael Plump 2006-03-24 18:27:17 UTC
Created attachment 61934 [details] [review]
Patch to make evince use goption instead of popt

I admit that I don't know how to make the --page-label option do anything, so I didn't actually test that part.
Comment 7 Luca Ferretti 2006-03-24 20:27:55 UTC
BTW it seems there is a page about this on wiki.

http://live.gnome.org/GnomeGoals/PoptGOption
Comment 8 Nickolay V. Shmyrev 2006-05-13 04:54:51 UTC
Applied, thanks.