After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327494 - Drag of album to queue results in wrong order
Drag of album to queue results in wrong order
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-18 08:07 UTC by Mattias Eriksson
Modified: 2006-01-29 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (41.39 KB, patch)
2006-01-23 22:30 UTC, Jonathan Matthew 		none Details | Review
better patch (41.80 KB, patch)
2006-01-27 09:45 UTC, Jonathan Matthew 		none Details | Review
updated (41.86 KB, patch)
2006-01-28 23:02 UTC, Jonathan Matthew 		committed Details | Review

Description Mattias Eriksson 2006-01-18 08:07:25 UTC 
Please describe the problem:
I have the queue as a sidebar. When I drag an album to the queue it seems to get
added in some random order. The prefered sortorder would be the same order as
the tracks are shown in the browser.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Jonathan Matthew 2006-01-23 22:30:38 UTC 
Created attachment 57967 [details] [review]
patch

Lots of rearranging of code to make the changes in rhythmdb-property-model.c that actually fix the bug possible.  I'm not entirely sure about the sort functions chosen for uri list drag data.  It currently acts as if you sorted the entry view on the property you're selecting (genre/artist/album), then selected all the entries for the values you're interested in.
Comment 2 Jonathan Matthew 2006-01-27 09:45:39 UTC 
Created attachment 58199 [details] [review]
better patch

Stops rhythmdb_query_model_set_sort_order complaining about resorting limited models when setting the sort order for the first time.
Comment 3 Jonathan Matthew 2006-01-28 23:02:28 UTC 
Created attachment 58296 [details] [review]
updated

now compiles with --enable-more-warnings
Comment 4 James "Doc" Livingston 2006-01-29 03:32:27 UTC 
Looks sane to me, and work fine.
Comment 5 Jonathan Matthew 2006-01-29 09:45:31 UTC 
Committed.