GNOME Bugzilla – Bug 327357
gst-plugins-base fails to compile with GCC 4.1
Last modified: 2006-03-21 15:01:57 UTC
cc1: warnings being treated as errors gstringbuffer.c: In function 'build_linear_format': gstringbuffer.c:173: warning: dereferencing type-punned pointer will break strict-aliasing rules gstringbuffer.c:192: warning: dereferencing type-punned pointer will break strict-aliasing rules
Created attachment 57664 [details] [review] proposed fix Does this fix it?
With this patch added I think it goes further as I now get: cc1: warnings being treated as errors gstcddabasesrc.c: In function 'gst_cdda_base_src_handle_event': gstcddabasesrc.c:851: warning: value computed is not used gstcddabasesrc.c:858: warning: value computed is not used make[4]: *** [libgstcdda_0.10_la-gstcddabasesrc.lo] Error 1
Could you do % make ERROR_CFLAGS="" 2> warnings.log and paste the whole bunch of them, so we don't have to do it on a per-file basis? :) I bet there's a whole bunch more because of that gcc bug with gst_event_ref()/gst_buffer_ref() ...
gstcddabasesrc.c: In function 'gst_cdda_base_src_handle_event': gstcddabasesrc.c:851: warning: value computed is not used gstcddabasesrc.c:858: warning: value computed is not used gstplaybin.c: In function 'handoff': gstplaybin.c:375: warning: dereferencing type-punned pointer will break strict-aliasing rules gstplaybin.c: In function 'gst_play_bin_send_event_to_sink': gstplaybin.c:940: warning: value computed is not used gststreamselector.c: In function 'gst_stream_selector_set_property': gststreamselector.c:202: warning: dereferencing type-punned pointer will break strict-aliasing rules gstmultifdsink.c: In function 'gst_multi_fd_sink_client_queue_buffer': gstmultifdsink.c:850: warning: value computed is not used gstmultifdsink.c: In function 'gst_multi_fd_sink_render': gstmultifdsink.c:1510: warning: value computed is not used ximagesink.c: In function 'gst_ximage_buffer_finalize': ximagesink.c:220: warning: value computed is not used xvimagesink.c: In function 'gst_xvimage_buffer_finalize': xvimagesink.c:293: warning: value computed is not used gstoggdemux.c: In function 'gst_ogg_pad_dispose': gstoggdemux.c:280: warning: dereferencing type-punned pointer will break strict-aliasing rules gstoggdemux.c:281: warning: dereferencing type-punned pointer will break strict-aliasing rules gstoggdemux.c:282: warning: dereferencing type-punned pointer will break strict-aliasing rules gstoggdemux.c: In function 'gst_ogg_demux_send_event': gstoggdemux.c:2408: warning: value computed is not used gstoggmux.c: In function 'gst_ogg_mux_get_headers': gstoggmux.c:755: warning: value computed is not used gstoggmux.c: In function 'gst_ogg_mux_send_headers': gstoggmux.c:871: warning: value computed is not used gstoggparse.c: In function 'gst_ogg_parse_chain': gstoggparse.c:437: warning: value computed is not used gstoggparse.c:473: warning: value computed is not used gstoggparse.c:489: warning: value computed is not used seek.c: In function ‘send_event’: seek.c:1024: warning: value computed is not used seek.c:1037: warning: value computed is not used
Created attachment 61545 [details] [review] Fix for all warnings in plugins-base with gcc 4.1 This one should cover all warnings. Works fine here, including make check.
Fixed, closing bug. 2006-03-21 Edward Hervey <edward@fluendo.com> * ext/ogg/gstoggdemux.c: (gst_ogg_pad_dispose): * gst/playback/gstplaybin.c: (handoff): * gst/playback/gststreamselector.c: (gst_stream_selector_set_property): gcc 4.1 unreferenced pointer fixes. * sys/ximage/ximagesink.c: (gst_ximagesink_ximage_put): * sys/xvimage/xvimagesink.c: (gst_xvimagesink_xvimage_put): gst_buffer_ref() now takes a GstBuffer*.