After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327221 - uses wrong translation in new preferred apps applet
uses wrong translation in new preferred apps applet
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-16 16:09 UTC by Christian Persch
Modified: 2006-01-17 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
default-applications-transtate-xml.patch (2.63 KB, patch)
2006-01-17 13:39 UTC, Luca Cavalli
none Details | Review

Description Christian Persch 2006-01-16 16:09:48 UTC
See the screenshot at http://www.gnome.org/~chpe/images/new-prefapp-weirdness.png where in the drop-down it uses strings in Zulu (zu)! (my locale is fr_FR)
Comment 1 Rodrigo Moya 2006-01-17 10:35:09 UTC
The handling of the applications list is wrong, since it is reading all the translations in the resulting gnome-default-applications.xml file, resulting in Chinese strings, for instance, as part of the lists.

Talking yesterday with Seb, we came to the conclusion that there is no need to use a XML file, rather just use an array, as before, or, if you still want to use a file, use GKeyFile to read it, which is able to retrieve the strings in the current language.

Luca, can you provide a patch for that? I think the best is to use the array, as we did before.
Comment 2 Luca Cavalli 2006-01-17 10:51:07 UTC
Since application name doesn't really need translation (can you confirm this?) I will prepare a patch to use an array instead of XML file.
Comment 3 Rodrigo Moya 2006-01-17 10:57:31 UTC
Not the app name, but the app description you use in gnome-default-applications.xml.in. That is merged with all translations from the po/ directory.
Comment 4 Luca Cavalli 2006-01-17 11:18:37 UTC
yes, sorry, I meant the <_name> tag. What about a patch using xmlNodeGetLang instead of reverting to the array? Or will a static data structure be safer?
Comment 5 Rodrigo Moya 2006-01-17 11:23:55 UTC
oh, didn't know about that, could you provide a patch with that? If it works, we can leave it for 2.14. A static array is simpler, but if you can make it work with the current code, go ahead.
Comment 6 Luca Cavalli 2006-01-17 13:39:14 UTC
Created attachment 57534 [details] [review]
default-applications-transtate-xml.patch

I prepared a patch using xmlNodeGetLang. It is inspired by the patch of bug #160700. At the moment I'm at work (I made the patch during lunch time) and I can't test it. Can someone confirm it fixes the problem? Otherwise I will made a patch removing xml code and reverting to static array.
Thanks.
Comment 7 Rodrigo Moya 2006-01-17 15:48:07 UTC
This fixes it, thanks!