After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327075 - [qtdemux] add support for palettized SMC videos
[qtdemux] add support for palettized SMC videos
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-15 15:15 UTC by Fabrizio Gennari
Modified: 2006-05-03 21:51 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch to add support for QuickTime SMC files and QuickTime 256-colour palette files (9.08 KB, patch)
2006-01-15 15:15 UTC, Fabrizio Gennari
none Details | Review

Description Fabrizio Gennari 2006-01-15 15:15:02 UTC
I have a QuickTime (.mov) file with fourcc 'SMC ' and a 256-colour palette. This
does not play with current GStreamer.

This patch adds support for that file. Actually, it should add support for all
QuickTime with 256-colour or 256-shades-of-gray palettes, but I do not have
files to test the general case.
Comment 1 Fabrizio Gennari 2006-01-15 15:15:52 UTC
Created attachment 57406 [details] [review]
Patch to add support for QuickTime SMC files and QuickTime 256-colour palette files
Comment 2 Fabrizio Gennari 2006-01-15 15:17:45 UTC
While writing the patch, I looked a lot at FFmpeg's code (especially mov.c and qtpalette.h in libavformat). However this should not present license problems as FFmpeg is LGPL'ed
Comment 3 Tim-Philipp Müller 2006-01-27 17:59:03 UTC
Any chance you could make that file that you have available to us for testing?
Comment 4 Tim-Philipp Müller 2006-02-24 19:50:29 UTC
Committed with the following changes:
 - reformat default palette tables to make full use of the line width
   instead of using up one line for each value
 - use palette data directly for palette buffer, without copying the data
 - use 32-bit integers for the palette tables, not ints (otherwise the
   palette data won't be picked up correctly on 64-bit architectures, will it?)

Thanks for the patch!

2006-02-24  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/qtdemux/qtdemux.c: (gst_qtdemux_add_stream),
        (qtdemux_parse_trak), (qtdemux_video_caps):
          Add support for palettised Apple SMC videos (#327075, based on
          patch by: Fabrizio Gennari <fabrizio dot ge at tiscali dot it>).