After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326890 - Clicking `Help' in gnome-power-preferences does not lauch the yelp file
Clicking `Help' in gnome-power-preferences does not lauch the yelp file
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-preferences
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-01-13 19:40 UTC by Richard Hughes
Modified: 2006-01-19 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch in question. (1.04 KB, patch)
2006-01-13 19:40 UTC, Richard Hughes 		none Details | Review
patch (1.56 KB, patch)
2006-01-19 15:51 UTC, William Jon McCann 		committed Details | Review

Description Richard Hughes 2006-01-13 19:40:17 UTC 
When I click `Help' in gnome-power-preferences it does not lauch the yelp file.
I'll attach a patch, but it does not work: I get,

** (gnome-power-preferences:3825): WARNING **: Unable to find the help files in either /home/hughsie/.root/share/gnome/help/./gnome-power-preferences/ or /usr/share/gnome/help/.  Please check your installation

i.e. it's looking in the g-p-p folder rather than in the g-p-m folder.

Not sure if I should split the yelp file into g-p-m and g-p-p specific parts, as this would solve the problem, but there must be another way.

Ideas welcome.
Comment 1 Richard Hughes 2006-01-13 19:40:53 UTC 
Created attachment 57305 [details] [review]
The patch in question.
Comment 2 Ray Strode [halfline] 2006-01-18 17:41:53 UTC 
does

gnome_help_display_with_doc_id (NULL, "gnome-power-manager", "gnome-power-manager.xml", NULL, &error);

work instead?
Comment 3 William Jon McCann 2006-01-19 15:51:45 UTC 
Created attachment 57650 [details] [review]
patch

Thanks Ray, that works.  OK to commit?
Comment 4 Richard Hughes 2006-01-19 16:19:51 UTC 
Feaky, I was just testing that new code.....

I get:

** (gnome-power-preferences:23864): WARNING **: Unable to find the help files in either /home/hughsie/.root/share/gnome/help/./gnome-power-preferences/ or /usr/share/gnome/help/.  Please check your installation

on Fedora Core 4 (Gnome 2.10...) but it works on Rawhide (Gnome 2.13.x), which I'm guessing is because of bug http://bugzilla.gnome.org/show_bug.cgi?id=82140 and why I couldn't get it to work on my development machine.

Good to commit.

Thanks Ray and Jon.
Comment 5 William Jon McCann 2006-01-19 16:48:59 UTC 
Committed.

2006-01-19  William Jon McCann  <mccann@jhu.edu>

	* src/gpm-prefs.c (gpm_prefs_help_cb): Use gnome_help.
	Fixes #326890