Bug 326862 – crash deleting podcast feed

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 326862 - crash deleting podcast feed


Summary:	crash deleting podcast feed


Status:	RESOLVED FIXED

Product:	rhythmbox
Classification:	Other
Component:	Podcast
Version:	HEAD
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	RhythmBox Maintainers
QA Contact:	RhythmBox Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2006-01-13 15:43 UTC by William Jon McCann
Modified:	2006-01-14 08:06 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch (959 bytes, patch) 2006-01-14 02:56 UTC, Jonathan Matthew	committed	Details \| Review

Description William Jon McCann 2006-01-13 15:43:27 UTC

Select delete feed and files.

0x00898402 in __kernel_vsyscall ()

+ Trace 65186

Thread 1 (Thread -1208957248 (LWP 1635))

#0 __kernel_vsyscall
#1 __waitpid_nocancel
from /lib/libpthread.so.0
#2 libgnomeui_segv_handle
at gnome-ui-init.c line 786

Comment 1 Jonathan Matthew 2006-01-14 02:56:24 UTC

Created attachment 57320 [details] [review]
patch

If RHYTHMDB_PROP_MOUNTPOINT for a podcast episode is NULL, it means the episode has not been downloaded, so it doesn't need to be deleted from disk.
Also fixes another warning from rb_podcast_source_cmd_delete_feed.

Comment 2 James "Doc" Livingston 2006-01-14 03:05:44 UTC

Patch looks good to me.

Comment 3 Jonathan Matthew 2006-01-14 03:08:03 UTC

Actually, I just had some weirdness occur when I deleted a podcast feed while an episode was still downloading.  The episode remained in the database, but the feed was gone, and trying to delete the episode caused a segfault.

Comment 4 Jonathan Matthew 2006-01-14 08:06:06 UTC

Committed (including a fix for the issue in comment #3).