After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326704 - [ffdec] Memory leak when joining pcache
[ffdec] Memory leak when joining pcache
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-12 09:59 UTC by Michal Benes
Modified: 2006-01-17 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix leak when joining cache to inbuf. (881 bytes, patch)
2006-01-12 10:01 UTC, Michal Benes 		none Details | Review
Fix leak when joining cache to inbuf. (690 bytes, patch)
2006-01-12 15:42 UTC, Michal Benes 		committed Details | Review

Description Michal Benes 2006-01-12 09:59:40 UTC 
In _chain function, ffdec joins pcache and inbuf gst_buffer_span and never use these buffers lates, but the original buffers are never unreferenced.
Comment 1 Michal Benes 2006-01-12 10:01:21 UTC 
Created attachment 57207 [details] [review]
Fix leak when joining cache to inbuf.

This patch properly unreferences pcache and inbuf that are never used after they are spanned to a new inbuf.
Comment 2 Jan Schmidt 2006-01-12 15:25:25 UTC 
Using gst_buffer_join instead of gst_buffer_span has the same effect.
Comment 3 Michal Benes 2006-01-12 15:42:55 UTC 
Created attachment 57231 [details] [review]
Fix leak when joining cache to inbuf.

Thanks, this is an updated version of the patch using gst_buffer_join.
Comment 4 Edward Hervey 2006-01-17 09:26:57 UTC 
2006-01-17  Edward Hervey  <edward@fluendo.com>

	* ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_chain):
	Memleak fix.
	Closes #326704