GNOME Bugzilla – Bug 326649
keynav: Navigating the Preferences dialog is inconsistent.
Last modified: 2013-09-10 14:04:09 UTC
Evolution 2.4.X, GNOME 2.12 on Solaris x86 Bring up the Evolution Preferences dialog (Alt-E, Up Arrow, Return). The Focus will be on the Mail Accounts image in the top left corner. You can use the Down arrow to navigate to the various option pages (Autocompletion, Mail Preferences, Composer Preferences, Calendar and Tasks, Certificates). Compare this with: Bring up the Evolution Preferences dialog (Alt-E, Up Arrow, Return). The Focus will be on the Mail Accounts image in the top left corner. Use Tab to visit components in the dialog: Tab to get to the Add button Tab to get to the Help button Tab to get to the Close button Tab to return to the Mail Accounts image in the top left corner. Now use Down arrow to try to select the other option pages. It'll select Autocompletion, but the Focus is no longer with that Autocompletion image, making further navigation with the down arrow bogus. There needs to be consistent navigation of components in this dialog.
Created attachment 57453 [details] [review] make the preference's keyboard navigation more consistent
targetting, confirming. hmm. starting the preferences and tabbing around for a two times leads to totally confusing results in 2.5.4 - it activates some more buttons of the account manager: accounts > add > help > close > accounts > accounts_list > add > edit > remove > default > disable > help > close so please review attached patch. tia. adding srag to cc.
Comment on attachment 57453 [details] [review] make the preference's keyboard navigation more consistent >? PerferenceKeyNav.diff >Index: ChangeLog >=================================================================== >RCS file: /cvs/gnome/evolution/widgets/misc/ChangeLog,v >retrieving revision 1.396 >diff -u -r1.396 ChangeLog >--- ChangeLog 13 Jan 2006 16:19:36 -0000 1.396 >+++ ChangeLog 16 Jan 2006 06:04:40 -0000 >@@ -1,3 +1,10 @@ >+2006-01-16 set Nancy Cai <nancy.cai@sum.com> >+ >+ ** Fixes bug #326649 >+ >+ * e-multi-config-dialog.c: (set_page_timeout_callback): >+ make the preferences dialog's keyboard navigation more consistent. >+ > 2006-01-13 Srinivasa Ragavan <sragavan@novell.com> > > ** Fixes bug #326265 >Index: e-multi-config-dialog.c >=================================================================== >RCS file: /cvs/gnome/evolution/widgets/misc/e-multi-config-dialog.c,v >retrieving revision 1.34 >diff -u -r1.34 e-multi-config-dialog.c >--- e-multi-config-dialog.c 4 Aug 2005 04:56:54 -0000 1.34 >+++ e-multi-config-dialog.c 16 Jan 2006 06:04:40 -0000 >@@ -122,6 +122,7 @@ > gtk_notebook_set_page (GTK_NOTEBOOK (priv->notebook), priv->set_page_timeout_page); > > priv->set_page_timeout_id = 0; >+ gtk_widget_grab_focus(priv->list_e_table); > return FALSE; > } >
Cai Nan, Are you sure that, it fixes for u. It doesnt even work for me... U didntmiss any files right?
Created attachment 57717 [details] [review] fix the bug for comment 2 This patch make the cursor transfer in the same order.
Created attachment 57887 [details] [review] fix the bug for comment 2
Created attachment 57889 [details] [review] make the preference's keyboard navigation more consistent
Nancy, you patch looks awesome. You have a cvs account to commit? Or shall i do it?
Srinivasa, please help me to commit it. Thanks.
Patches have already been committed.Please close it. Thanks.
Fixed to HEAD.
Good fix! Works nicely for me. Many thanks.