After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326602 - id3demux is not compiling without ZLIB
id3demux is not compiling without ZLIB
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-11 14:27 UTC by Sergey Scobich
Modified: 2006-01-15 20:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for fixing id3v2frames.c compilation without ZLIB (954 bytes, patch)
2006-01-11 14:29 UTC, Sergey Scobich 		none Details | Review

Description Sergey Scobich 2006-01-11 14:27:47 UTC 
id3demux plugin (id3v2frames.c) is not compiling without ZLIB:

uLongf - undeclared identifier
Bytef - undeclared identifier
Z_OK - undeclared identifier
...

Actually there are two ways of fixing this.
1. Remove #ifdef HAVE_ZLIB from the top of the source file and make ZLIB a requirement for this plugin.
2. Apply the patch below to fix compilation and report that compressed frames could not be processed if plugin is compiled without ZLIB. The same is done now for Encrypted frames.
Comment 1 Sergey Scobich 2006-01-11 14:29:12 UTC 
Created attachment 57156 [details] [review]
patch for fixing id3v2frames.c compilation without ZLIB
Comment 2 Sergey Scobich 2006-01-11 14:30:38 UTC 
Comment on attachment 57156 [details] [review]
patch for fixing id3v2frames.c compilation without ZLIB

Please correct user message because I'm afraid it's not a clean English.
Comment 3 Jan Schmidt 2006-01-11 15:29:47 UTC 
Thanks for the patch. I've applied it locally (and changed the warning message), but I can't commit just yet because gst-plugins-good is frozen for release. I'll commit it tomorrow.
Comment 4 Jan Schmidt 2006-01-15 20:24:49 UTC 
A bit later than 'tomorrow', but got there in the end. Fixed in CVS:

        * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame):
          Fix compilation of id3demux when zlib is not present.
          (Fixes #326602; patch by: Sergey Scobich)