GNOME Bugzilla – Bug 326571
Evolution converts *space* in filename to *underscore* when saving attachments
Last modified: 2013-09-13 00:48:23 UTC
Please describe the problem: If text attachment filenames contain *space* or printable characters, such as "/'\"`&();|<>$%{}!", they will be automatically converted to *underscore* when saving attachments. These characters are valid on Unix. Steps to reproduce: 1. Send and receive an e-mail with attachment whose orginal filename contains spaces. 2. Save this file somewhere. Actual results: Spaces in the filename are replaced with underscores. Expected results: Keep the spaces in filename. Does this happen every time? yes. Other information: This conversation is done by e_filename_make_safe() (e-d-s/libedataserver/e-data-server-util.c). I think some printable character is uncessary to limit.
i've already seen this in bugzilla, but i cannot find the duplicate.
Created attachment 58582 [details] [review] Now filenames will retain spaces when saving attachments
I doesnt say 'invalid' it is said 'unsafe'. Even if we want to fix this, I wouldnt prefer doing this way, since this fn is used in many other functions and I would prefer cloning this fucntion for saving attachments along locally in that file. Im rejecting the patch.
Adding rajeev to CC to rework on that patch.
Created attachment 60906 [details] [review] clone a copy in local file Srag, I clone a copy from e-d-s and make a bit changes, then use it to allow attachment names contain more valid characters when saving attachment.
Looks good to commit to both HEAD and 2-14 branch.
Committed the patch to CVS HEAD and gnome-2-14 branch.